Skip to content

Migrate source mssql from old CDK to new CDK - #63731

Merged
Wenqi Hu (burakku) merged 15 commits into
masterfrom
wenqi-mssql-migration
Oct 29, 2025
Merged

Wenqi Hu (burakku) merged 15 commits into
masterfrom
wenqi-mssql-migration

Conversation

@burakku

Copy link
Copy Markdown
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel

vercel Bot commented Jul 23, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Jul 23, 2025 7:40am

@github-actions

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@github-actions

github-actions Bot commented Jul 23, 2025 •

Copy link
Copy Markdown
Contributor

source-mssql-v2 Connector Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7b41d01.

♻️ This comment has been updated with latest results.

@burakku
Wenqi Hu (burakku) force-pushed the wenqi-mssql-migration branch 2 times, most recently from 9a4ae16 to 66ff966 Compare September 2, 2025 22:53
@github-actions

github-actions Bot commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

destination-dev-null Connector Test Results

47 tests   15 ✅  39s ⏱️
 4 suites  32 💤
 4 files     0 ❌

Results for commit fc52150.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

destination-customer-io Connector Test Results

48 tests   18 ✅  25s ⏱️
 7 suites  30 💤
 7 files     0 ❌

Results for commit fc52150.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

destination-hubspot Connector Test Results

44 tests   14 ✅  25s ⏱️
 5 suites  30 💤
 5 files     0 ❌

Results for commit fc52150.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

source-mysql Connector Test Results

  8 files    8 suites   27s ⏱️
 51 tests  51 ✅ 0 💤 0 ❌
175 runs  175 ✅ 0 💤 0 ❌

Results for commit fc52150.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

destination-mssql Connector Test Results

135 tests   117 ✅  7m 32s ⏱️
 12 suites   18 💤
 12 files      0 ❌

Results for commit fc52150.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

destination-s3 Connector Test Results

808 tests   459 ✅  2h 34m 35s ⏱️
 26 suites  349 💤
 26 files      0 ❌

Results for commit 66ff966.

@github-actions

github-actions Bot commented Sep 3, 2025 •

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-j498e88ed-airbyte-growth.vercel.app

Built with commit ade4ff3.
This pull request is being automatically deployed with vercel-action

@burakku
Wenqi Hu (burakku) force-pushed the wenqi-mssql-migration branch 3 times, most recently from a3b9731 to b0d1572 Compare September 5, 2025 23:56
@burakku
Wenqi Hu (burakku) force-pushed the wenqi-mssql-migration branch 2 times, most recently from f07ec67 to 7b41d01 Compare September 10, 2025 23:18
@burakku Wenqi Hu (burakku) changed the title Wenqi mssql migration Migrate source mssql from old CDK to new CDK Sep 11, 2025
@github-actions

github-actions Bot commented Sep 23, 2025 •

Copy link
Copy Markdown
Contributor

source-mssql Connector Test Results

  7 files    7 suites   14m 8s ⏱️
 61 tests  61 ✅ 0 💤 0 ❌
171 runs  171 ✅ 0 💤 0 ❌

Results for commit ade4ff3.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 2, 2025 •

Copy link
Copy Markdown
Contributor

Note

Detected that there are differences in the Gradle dependencies.

@burakku
Wenqi Hu (burakku) force-pushed the wenqi-mssql-migration branch 2 times, most recently from 98efdc7 to 392fbf9 Compare October 8, 2025 22:56
@burakku
Wenqi Hu (burakku) marked this pull request as ready for review October 8, 2025 22:58

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.3.0-rc.1 | 2025-10-28 | [63731](https://github.com/airbytehq/airbyte/pull/63731) | Migrate source mssql from old CDK to new CDK |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'mssql'?

@burakku
Wenqi Hu (burakku) force-pushed the wenqi-mssql-migration branch 2 times, most recently from 78a7f72 to 19b8677 Compare October 28, 2025 21:19
[Change Data Capture (CDC)](https://docs.airbyte.com/understanding-airbyte/cdc) using the
[binlog](https://dev.mysql.com/doc/refman/8.0/en/binary-log.html).
[Change Data Capture (CDC)](https://docs.airbyte.com/understanding-airbyte/cdc) using
[SQL Server's CDC feature](https://docs.microsoft.com/en-us/sql/relational-databases/track-changes/about-change-data-capture-sql-server).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'us'.

If you do not see a type in this list, assume that it is coerced into a string. We are happy to take
feedback on preferred mappings.

## Upgrading to version 4.3.0 and above

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.WordList] Use 'preceding' instead of 'above'.

- **Automatic State Migration**: The connector automatically migrates legacy version 2 state formats to the new version 3 format. This includes:
- `OrderedColumnLoadStatus` (primary key-based initial sync) → version 3 `primary_key` state type
- `CursorBasedStatus` (cursor-based incremental) → version 3 `cursor_based` state type
- **Backward Compatibility**: Existing connections will continue to work seamlessly without any manual intervention

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

@burakku
Wenqi Hu (burakku) merged commit a9afe95 into master Oct 29, 2025
3 checks passed
@burakku
Wenqi Hu (burakku) deleted the wenqi-mssql-migration branch October 29, 2025 06:56
devin-ai-integration Bot added a commit that referenced this pull request Dec 10, 2025
…r Agent check

This fixes a regression introduced in PR #63731 where Azure SQL Database
connections fail with 'Invalid object name sys.dm_server_services' error.

The fix adds an EngineEdition check before querying sys.dm_server_services:
- EngineEdition 5 (Azure SQL Database): Skip the check entirely
- EngineEdition 8 (Azure SQL Managed Instance): SQL Server Agent is always running
- Other editions: Perform the original sys.dm_server_services check

Also adds graceful error handling for SQLException to prevent connection
failures in restricted permission scenarios.

Fixes: airbytehq/oncall#10470
Co-Authored-By: unknown <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants