Skip to content

moved db version logging from mysql connector to CDK for all JDBC sou… - #64569

Merged
Davin Chia (davinchia) merged 19 commits into
masterfrom
jim/jdbc-logging-v3
Aug 13, 2025
Merged

moved db version logging from mysql connector to CDK for all JDBC sou…#64569
Davin Chia (davinchia) merged 19 commits into
masterfrom
jim/jdbc-logging-v3

Conversation

@jimruppert

Copy link
Copy Markdown
Contributor

moved db version logging from mysql connector to CDK , will handle all JDBC sources
logs only during check operation

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@jimruppert
Jim Ruppert (jimruppert) marked this pull request as draft August 8, 2025 22:38
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-hubspot Connector Test Results

44 tests   14 ✅  27s ⏱️
 5 suites  30 💤
 5 files     0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-azure-blob-storage Connector Test Results

340 tests   220 ✅  49m 28s ⏱️
 13 suites  120 💤
 13 files      0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-dev-null Connector Test Results

47 tests   15 ✅  40s ⏱️
 4 suites  32 💤
 4 files     0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-customer-io Connector Test Results

48 tests   18 ✅  24s ⏱️
 7 suites  30 💤
 7 files     0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-clickhouse Connector Test Results

 15 files   15 suites   3m 12s ⏱️
222 tests 181 ✅ 41 💤 0 ❌
242 runs  201 ✅ 41 💤 0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-mssql Connector Test Results

135 tests   117 ✅  7m 14s ⏱️
 12 suites   18 💤
 12 files      0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

source-mysql Connector Test Results

  8 files    8 suites   28s ⏱️
 51 tests  51 ✅ 0 💤 0 ❌
175 runs  175 ✅ 0 💤 0 ❌

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

destination-s3 Connector Test Results

808 tests   458 ✅  3h 18m 5s ⏱️
 26 suites  349 💤
 26 files      1 ❌

For more details on these failures, see this check.

Results for commit 7c17b6e.

♻️ This comment has been updated with latest results.

@jimruppert
Jim Ruppert (jimruppert) marked this pull request as ready for review August 8, 2025 22:44
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-4zw1aoye8-airbyte-growth.vercel.app

Built with commit 7c17b6e.
This pull request is being automatically deployed with vercel-action

@jimruppert
Jim Ruppert (jimruppert) marked this pull request as draft August 11, 2025 18:01
@jimruppert
Jim Ruppert (jimruppert) marked this pull request as ready for review August 11, 2025 23:38
@jimruppert

Copy link
Copy Markdown
Contributor Author

This PR moves the DB version logging from the mysql source connector to the CDK, so it will log for all JDBC sources.

@theyueli Yue Li (theyueli) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this CDK change, we would have to change build.gradle of source-mysql to use the current local cdk, e.g.,

airbyteBulkConnector {
    core = 'extract'
    toolkits = ['extract-jdbc', 'extract-cdc']
    cdk = 'local'
}

Then, change it back to use the newly published version (after this PR is merged)

    core = 'extract'
    toolkits = ['extract-jdbc', 'extract-cdc']
    cdk = '0.1.12'
}

Unless there is a revised flow possibly done by Edward Gao (@edgao)

@davinchia
Davin Chia (davinchia) merged commit a61f616 into master Aug 13, 2025
50 of 55 checks passed
@davinchia
Davin Chia (davinchia) deleted the jim/jdbc-logging-v3 branch August 13, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants