Repository navigation
chore: s3 cdk 7 migration - #66023
Merged
Merged
Conversation
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Contributor
|
Contributor
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 4ade5d2. |
| raise AssertionError("Expected records but got none.") # noqa: TRY003 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
Contributor
Author
There was a problem hiding this comment.
This test was failing and I can't figure out when it ever passed so I'm just going to remove it
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -356,6 +356,7 @@ This connector utilizes the open source [Unstructured](https://unstructured-io.g | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[markdownlint-fix] reported by reviewdog 🐶
Suggested change
| - "*.s3.amazonaws.com" | ||
| connectorBuildOptions: | ||
| baseImage: docker.io/airbyte/python-connector-base:4.0.1@sha256:111cbcb26795adcd42b03c3f29c8b6b7adbbfcb5c5192a520d9b8d399a976b22 | ||
| baseImage: docker.io/airbyte/python-connector-base:4.0.2@sha256:9fdb1888c4264cf6fee473649ecb593f56f58e5d0096a87ee0b231777e2e3e73 |
Contributor
Author
There was a problem hiding this comment.
It was interesting that image 4.0.1 did not exist anymore...
Brian Lai (brianjlai)
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?