Skip to content

chore: remove memory limits from certified GA destinations - #67078

Merged
Davin Chia (davinchia) merged 5 commits into
masterfrom
davinchia/remove-memory-limits
Oct 6, 2025
Merged

Davin Chia (davinchia) merged 5 commits into
masterfrom
davinchia/remove-memory-limits

Conversation

@davinchia

@davinchia Davin Chia (davinchia) commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

What

Remove memory_limit from sync job resourceRequirements for 4 certified GA destinations:

  • destination-s3 (1.9.2 → 1.9.3)
  • destination-bigquery (3.0.7 → 3.0.8)
  • destination-azure-blob-storage (1.1.1 → 1.1.2)

This change improves performance and resource utilization by removing artificial memory caps while keeping memory_request intact.

Limits are mostly a cost concern, and connector devs shouldn't need to set them to begin with.

🤖 Generated with Claude Code

How

Remove.

Excluding Redshift as those tests are failing.
Excluding Snowflake since it's actively being worked on. The change will happen in the next breaking change.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Remove memory_limit from sync job resourceRequirements for 4 certified GA destinations:
- destination-s3 (1.9.2 → 1.9.3)
- destination-bigquery (3.0.7 → 3.0.8)
- destination-azure-blob-storage (1.1.1 → 1.1.2)
- destination-redshift (3.5.3 → 3.5.4)

This change improves performance and resource utilization by removing artificial memory caps while keeping memory_request intact.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@davinchia
Davin Chia (davinchia) marked this pull request as ready for review October 6, 2025 05:04
@davinchia
Davin Chia (davinchia) requested a review from a team as a code owner October 6, 2025 05:04
@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
    Example: /update-connector-cdk-version connector=destination-bigquery
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

Davin Chia (davinchia) and others added 2 commits October 5, 2025 22:12
- Add changelog entries to docs for version updates
- Remove standalone CHANGELOG.md files in connector directories
- Changelogs are maintained in the documentation files per project convention

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Replace TBD with actual PR number 67078 in all documentation changelogs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

destination-azure-blob-storage Connector Test Results

340 tests   220 ✅  48m 43s ⏱️
 13 suites  120 💤
 13 files      0 ❌

Results for commit b52d15e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

destination-s3 Connector Test Results

808 tests   459 ✅  2h 34m 37s ⏱️
 26 suites  349 💤
 26 files      0 ❌

Results for commit b52d15e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

destination-bigquery Connector Test Results

 21 files   21 suites   1h 44m 20s ⏱️
449 tests 397 ✅ 51 💤 1 ❌
450 runs  398 ✅ 51 💤 1 ❌

For more details on these failures, see this check.

Results for commit b52d15e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

destination-redshift Connector Test Results

  9 files    9 suites   1h 6m 42s ⏱️
117 tests  87 ✅ 20 💤 10 ❌
141 runs  105 ✅ 20 💤 16 ❌

For more details on these failures, see this check.

Results for commit 1c6a6e4.

Reverting destination-redshift changes due to test failures. Will be handled separately.

- Restore version to 3.5.3
- Restore memory_limit in metadata.yaml
- Remove changelog entry from docs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-brenpy7p7-airbyte-growth.vercel.app

Built with commit 3aec2e3.
This pull request is being automatically deployed with vercel-action

@davinchia

Copy link
Copy Markdown
Contributor Author

Even though the build is red, all the other builds have passed at least one in separate runs, so I'm merging this in.

@davinchia
Davin Chia (davinchia) merged commit bc88891 into master Oct 6, 2025
39 of 41 checks passed
@davinchia
Davin Chia (davinchia) deleted the davinchia/remove-memory-limits branch October 6, 2025 17:36
Matteo Palarchio (matteogp) pushed a commit that referenced this pull request Oct 10, 2025
Remove memory_limit from sync job resourceRequirements for 4 certified GA destinations:

destination-s3 (1.9.2 → 1.9.3)
destination-bigquery (3.0.7 → 3.0.8)
destination-azure-blob-storage (1.1.1 → 1.1.2)
This change improves performance and resource utilization by removing artificial memory caps while keeping memory_request intact.

Limits are mostly a cost concern, and connector devs shouldn't need to set them to begin with.

🤖 Generated with Claude Code

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants