Skip to content

fix: revert cache change to fix performance issue - #68106

Merged
Jonathan Pearlin (jdpgrailsdev) merged 2 commits into
masterfrom
jonathan/cache-performance-fix
Oct 15, 2025
Merged

fix: revert cache change to fix performance issue#68106
Jonathan Pearlin (jdpgrailsdev) merged 2 commits into
masterfrom
jonathan/cache-performance-fix

Conversation

@jdpgrailsdev

@jdpgrailsdev Jonathan Pearlin (jdpgrailsdev) commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

What

  • Revert introduction of column cache to formatter to improve performance

How

  • Restore previous logic

Review guide

  • SnowflakeRecordFormatter.kt

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

github-actions[bot]
github-actions Bot reviewed Oct 15, 2025
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

docs/integrations/destinations/snowflake.md|358 col 104| [Vale.Spelling] Did you really mean 'Deallocate'?
docs/integrations/destinations/snowflake.md|359 col 139| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|360 col 130| [Vale.Spelling] Did you really mean 'PKs'?
docs/integrations/destinations/snowflake.md|360 col 152| [Vale.Spelling] Did you really mean 'dedupe'?
docs/integrations/destinations/snowflake.md|361 col 113| [Vale.Spelling] Did you really mean 'jvm'?
docs/integrations/destinations/snowflake.md|363 col 111| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|365 col 167| [Vale.Spelling] Did you really mean 'PKs'?
docs/integrations/destinations/snowflake.md|368 col 113| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|371 col 111| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|373 col 123| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|375 col 108| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|380 col 104| [Vale.Spelling] Did you really mean 'Reenable'?
docs/integrations/destinations/snowflake.md|380 col 136| [Vale.Spelling] Did you really mean 'deduping'?
docs/integrations/destinations/snowflake.md|381 col 119| [Vale.Spelling] Did you really mean 'deduping'?
docs/integrations/destinations/snowflake.md|382 col 113| [Vale.Spelling] Did you really mean 'Dedupe'?
docs/integrations/destinations/snowflake.md|383 col 104| [Vale.Spelling] Did you really mean 'Upcase'?
docs/integrations/destinations/snowflake.md|384 col 127| [write-good.Weasel] 'very' is a weasel word!
docs/integrations/destinations/snowflake.md|391 col 182| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|394 col 121| [write-good.Weasel] 'Several' is a weasel word!
docs/integrations/destinations/snowflake.md|394 col 149| [Vale.Spelling] Did you really mean 'cursorless'?
docs/integrations/destinations/snowflake.md|394 col 160| [Vale.Spelling] Did you really mean 'dedup'?
docs/integrations/destinations/snowflake.md|397 col 119| [Google.Colons] ': A' should be in lowercase.
docs/integrations/destinations/snowflake.md|407 col 112| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|409 col 112| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/destinations/snowflake.md|428 col 115| [Vale.Spelling] Did you really mean 'Avro'?
docs/integrations/destinations/snowflake.md|431 col 157| [Vale.Spelling] Did you really mean 'rethrow'?
docs/integrations/destinations/snowflake.md|432 col 134| [Vale.Spelling] Did you really mean 'checkpointing'?
docs/integrations/destinations/snowflake.md|433 col 132| [Vale.Spelling] Did you really mean 'rethrow'?
docs/integrations/destinations/snowflake.md|435 col 157| [Vale.Spelling] Did you really mean 'gcs'?
docs/integrations/destinations/snowflake.md|438 col 108| [Vale.Spelling] Did you really mean 'jdbc'?
docs/integrations/destinations/snowflake.md|438 col 113| [Google.WordList] Use 'app' instead of 'application'.
docs/integrations/destinations/snowflake.md|438 col 125| [Vale.Spelling] Did you really mean 'env'?
docs/integrations/destinations/snowflake.md|438 col 149| [Vale.Spelling] Did you really mean 'env'?
docs/integrations/destinations/snowflake.md|438 col 155| [Vale.Spelling] Did you really mean 'airbyte_oss'?
docs/integrations/destinations/snowflake.md|438 col 170| [Vale.Spelling] Did you really mean 'airbyte_cloud'?
docs/integrations/destinations/snowflake.md|443 col 116| [Vale.Spelling] Did you really mean 'Avro'?
docs/integrations/destinations/snowflake.md|446 col 112| [Vale.Spelling] Did you really mean 'additionalProperties'?
docs/integrations/destinations/snowflake.md|448 col 112| [Vale.Spelling] Did you really mean 'additionalProperties'?
docs/integrations/destinations/snowflake.md|453 col 153| [Vale.Spelling] Did you really mean 'purge_staging_files'?
docs/integrations/destinations/snowflake.md|470 col 108| [Vale.Spelling] Did you really mean 'jdbc_url_params'?
docs/integrations/destinations/snowflake.md|478 col 110| [Vale.Spelling] Did you really mean 'part_size'?
docs/integrations/destinations/snowflake.md|479 col 112| [Vale.Spelling] Did you really mean 'jdbc'?

Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
github-actions[bot]
github-actions Bot reviewed Oct 15, 2025
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

docs/integrations/destinations/snowflake.md|438 col 113| [Google.WordList] Use 'app' instead of 'application'.
docs/integrations/destinations/snowflake.md|438 col 125| [Vale.Spelling] Did you really mean 'env'?
docs/integrations/destinations/snowflake.md|438 col 149| [Vale.Spelling] Did you really mean 'env'?
docs/integrations/destinations/snowflake.md|438 col 155| [Vale.Spelling] Did you really mean 'airbyte_oss'?
docs/integrations/destinations/snowflake.md|438 col 170| [Vale.Spelling] Did you really mean 'airbyte_cloud'?
docs/integrations/destinations/snowflake.md|443 col 116| [Vale.Spelling] Did you really mean 'Avro'?
docs/integrations/destinations/snowflake.md|446 col 112| [Vale.Spelling] Did you really mean 'additionalProperties'?
docs/integrations/destinations/snowflake.md|448 col 112| [Vale.Spelling] Did you really mean 'additionalProperties'?
docs/integrations/destinations/snowflake.md|453 col 153| [Vale.Spelling] Did you really mean 'purge_staging_files'?
docs/integrations/destinations/snowflake.md|470 col 108| [Vale.Spelling] Did you really mean 'jdbc_url_params'?
docs/integrations/destinations/snowflake.md|478 col 110| [Vale.Spelling] Did you really mean 'part_size'?
docs/integrations/destinations/snowflake.md|479 col 112| [Vale.Spelling] Did you really mean 'jdbc'?

Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
Comment thread docs/integrations/destinations/snowflake.md
@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-ktz5wep19-airbyte-growth.vercel.app

Built with commit 1f66c48.
This pull request is being automatically deployed with vercel-action

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

destination-snowflake Connector Test Results

 26 files   26 suites   19m 6s ⏱️
318 tests 282 ✅ 36 💤 0 ❌
322 runs  286 ✅ 36 💤 0 ❌

Results for commit 1f66c48.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

destination-snowflake Connector Test Results

 26 files   26 suites   19m 9s ⏱️
318 tests 282 ✅ 36 💤 0 ❌
322 runs  286 ✅ 36 💤 0 ❌

Results for commit 1f66c48.

@jdpgrailsdev
Jonathan Pearlin (jdpgrailsdev) merged commit 3eab227 into master Oct 15, 2025
35 checks passed
@jdpgrailsdev
Jonathan Pearlin (jdpgrailsdev) deleted the jonathan/cache-performance-fix branch October 15, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
+1 more reviewer
@edgao Edward Gao (edgao) edgao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

connectors/destination/snowflake

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdpgrailsdev @edgao @octavia-squidington-iii