Destination snowflake: component tests by edgao · Pull Request #68125 · airbytehq/airbyte

Edward Gao (edgao) · 2025-10-15T21:59:31Z

What

The connectors' half of part of 1 of https://github.com/airbytehq/airbyte-internal-issues/issues/14865. Branched from #68167. Implement the new test interfaces in dest-snowflake + add (most) of the tests.

How

Just do it. (also bump dest-clickhouse to local cdk, to verify I didn't break anything)

Can this PR be safely reverted and rolled back?

YES 💚
NO ❌

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

github-actions · 2025-10-15T21:59:55Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

/format-fix - Fixes most formatting issues.
/bump-version - Bumps connector versions.
- You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
- Leaving the changelog arg blank will auto-populate the changelog from the PR title.
/run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
/build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
JVM connectors:
- /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
  Example: /update-connector-cdk-version connector=destination-bigquery
- /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
Python connectors:
- /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
- /poe source example lock - Alias for /poe connector source-example lock.
- /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
- /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

github-actions · 2025-10-15T22:04:09Z

`destination-snowflake` Connector Test Results

27 files 27 suites 22m 1s ⏱️
329 tests 293 ✅ 36 💤 0 ❌
333 runs 297 ✅ 36 💤 0 ❌

Results for commit 5f69b52.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-15T22:04:15Z

Note

Detected that there are differences in the Gradle dependencies.

github-actions · 2025-10-15T22:05:40Z

`destination-clickhouse` Connector Test Results

14 files 14 suites 22m 50s ⏱️
283 tests 234 ✅ 49 💤 0 ❌
313 runs 264 ✅ 49 💤 0 ❌

Results for commit 5f69b52.

♻️ This comment has been updated with latest results.

Edward Gao (edgao) · 2025-10-17T20:12:00Z

-                    connection.prepareStatement(
-                        """
+    /**
+     * TEST ONLY. We have a much more performant implementation in


Increasingly convinced we should split this into a separate TestTableOps interface. Will do that in https://github.com/airbytehq/airbyte-internal-issues/issues/14912

…mponent_tests

Jonathan Pearlin (jdpgrailsdev) · 2025-10-28T12:39:04Z

@@ -1 +1 @@
-cdkVersion=0.1.52
+cdkVersion=local


I assume that you don't want to commit this change.

yep, PR checks will block this anyway. This is just to get CI to run against the CDK changes

Jonathan Pearlin (jdpgrailsdev) · 2025-10-28T12:39:12Z

@@ -1,3 +1,3 @@
 testExecutionConcurrency=-1
-cdkVersion=0.1.52
+cdkVersion=local


Same comment.

Jonathan Pearlin (jdpgrailsdev)

assuming confirmation or revert of the cdk version changes in this PR.

# Conflicts: # airbyte-integrations/connectors/destination-clickhouse/gradle.properties # airbyte-integrations/connectors/destination-snowflake/gradle.properties # airbyte-integrations/connectors/destination-snowflake/src/main/kotlin/io/airbyte/integrations/destination/snowflake/client/SnowflakeAirbyteClient.kt

github-actions · 2025-10-28T17:12:26Z

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-43ffmxr69-airbyte-growth.vercel.app

Built with commit 5f69b52.
This pull request is being automatically deployed with vercel-action

Octavia Squidington III (octavia-squidington-iii) added the connectors/destination/snowflake label Oct 15, 2025

github-actions Bot added the dependencies-change label Oct 15, 2025

Ryan Br... (tryangul) force-pushed the rbroughan/component-tests-operations-test-1 branch from 57e52d2 to f967fcc Compare October 15, 2025 23:24

Base automatically changed from rbroughan/component-tests-operations-test-1 to master October 16, 2025 18:19

Octavia Squidington III (octavia-squidington-iii) added the connectors/destination/clickhouse label Oct 16, 2025

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch from 391845e to efec600 Compare October 17, 2025 18:12

Edward Gao (edgao) changed the base branch from master to edgao/component_test_cdk_stuff October 17, 2025 18:12

Edward Gao (edgao) force-pushed the edgao/component_test_cdk_stuff branch from dd20b70 to 649d28a Compare October 17, 2025 18:14

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch 2 times, most recently from 3e723d8 to e8faa99 Compare October 17, 2025 18:19

Edward Gao (edgao) force-pushed the edgao/component_test_cdk_stuff branch 2 times, most recently from 1500032 to 1c3eb77 Compare October 17, 2025 19:41

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch from e8faa99 to c572e8a Compare October 17, 2025 19:41

Edward Gao (edgao) force-pushed the edgao/component_test_cdk_stuff branch from 1c3eb77 to 8761488 Compare October 17, 2025 20:00

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch from c572e8a to 2a3d816 Compare October 17, 2025 20:00

Edward Gao (edgao) added 3 commits October 17, 2025 13:00

insert records have airbyte_ columns

c6a8ff7

add ColumnNameMapping#originalName

8782891

insert+read back with columnNameMapping

5e87d52

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch from 2a3d816 to a9bf914 Compare October 17, 2025 20:01

Edward Gao (edgao) force-pushed the edgao/component_test_cdk_stuff branch from 8761488 to 5e87d52 Compare October 17, 2025 20:01

connector changes

f2d927e

Edward Gao (edgao) force-pushed the edgao/snowflake_component_tests branch from a9bf914 to f2d927e Compare October 17, 2025 20:06

Edward Gao (edgao) commented Oct 17, 2025

View reviewed changes

Edward Gao (edgao) requested a review from Jonathan Pearlin (jdpgrailsdev) October 17, 2025 20:12

Edward Gao (edgao) marked this pull request as ready for review October 17, 2025 20:12

Edward Gao (edgao) requested a review from a team as a code owner October 17, 2025 20:12

Edward Gao (edgao) mentioned this pull request Oct 20, 2025

Edgao/component upsert tests/cdk #68185

Merged

1 of 2 tasks

Edward Gao (edgao) added 3 commits October 20, 2025 14:15

better invert impl

8cfdaa0

util method for creating record

7c316de

Merge branch 'edgao/component_test_cdk_stuff' into edgao/snowflake_co…

5313d57

…mponent_tests

Jonathan Pearlin (jdpgrailsdev) reviewed Oct 28, 2025

View reviewed changes

Jonathan Pearlin (jdpgrailsdev) approved these changes Oct 28, 2025

View reviewed changes

Base automatically changed from edgao/component_test_cdk_stuff to master October 28, 2025 15:41

Edward Gao (edgao) added 2 commits October 28, 2025 09:54

logistics

5f69b52

Edward Gao (edgao) enabled auto-merge (squash) October 28, 2025 17:03

Edward Gao (edgao) merged commit a8eb285 into master Oct 28, 2025
41 checks passed

Edward Gao (edgao) deleted the edgao/snowflake_component_tests branch October 28, 2025 17:16

Francis Genet (frifriSF59) pushed a commit that referenced this pull request Nov 4, 2025

Destination snowflake: component tests (#68125)

85bb543

Navigation Menu

Repository navigation

Destination snowflake: component tests - #68125

Destination snowflake: component tests#68125
Edward Gao (edgao) merged 9 commits into
masterfrom
edgao/snowflake_component_tests

Edward Gao (edgao) commented Oct 15, 2025 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Oct 15, 2025

Uh oh!

github-actions Bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

Edward Gao (edgao) Oct 17, 2025 •

edited

Loading

Uh oh!

Jonathan Pearlin (jdpgrailsdev) Oct 28, 2025

Uh oh!

Edward Gao (edgao) Oct 28, 2025

Uh oh!

Jonathan Pearlin (jdpgrailsdev) Oct 28, 2025

Uh oh!

Jonathan Pearlin (jdpgrailsdev) left a comment

Uh oh!

github-actions Bot commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1 +1 @@
		cdkVersion=0.1.52
		cdkVersion=local

Conversation

Edward Gao (edgao) commented Oct 15, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Can this PR be safely reverted and rolled back?

Uh oh!

github-actions Bot commented Oct 15, 2025

👋 Greetings, Airbyte Team Member!

Helpful Resources

PR Slash Commands

Uh oh!

github-actions Bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

destination-snowflake Connector Test Results

Uh oh!

github-actions Bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

destination-clickhouse Connector Test Results

Uh oh!

Edward Gao (edgao) Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jonathan Pearlin (jdpgrailsdev) Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Edward Gao (edgao) Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Jonathan Pearlin (jdpgrailsdev) Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Jonathan Pearlin (jdpgrailsdev) left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Edward Gao (edgao) commented Oct 15, 2025 •

edited by github-actions Bot

Loading

github-actions Bot commented Oct 15, 2025 •

edited

Loading

`destination-snowflake` Connector Test Results

github-actions Bot commented Oct 15, 2025 •

edited

Loading

github-actions Bot commented Oct 15, 2025 •

edited

Loading

`destination-clickhouse` Connector Test Results

Edward Gao (edgao) Oct 17, 2025 •

edited

Loading