Repository navigation
Edgao/component upsert tests/connectors - #68186
Merged
Edward Gao (edgao) merged 29 commits intoOct 29, 2025
Merged
Conversation
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Contributor
|
Contributor
|
Edward Gao (edgao)
force-pushed
the
edgao/component_upsert_tests/cdk
branch
from
October 20, 2025 16:55
34fc6e7 to
8d94d4a
Compare
Edward Gao (edgao)
force-pushed
the
edgao/component_upsert_tests/connectors
branch
from
October 20, 2025 16:55
7f417e8 to
3d46ccc
Compare
Edward Gao (edgao)
marked this pull request as ready for review
October 20, 2025 16:55
1 of 2 tasks
…psert_tests/cdk # Conflicts: # airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/component/TableOperationsFixtures.kt
…upsert_tests/connectors
# Conflicts: # airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/component/TableOperationsFixtures.kt # airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/component/TableOperationsSuite.kt # airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/component/TableOperationsTestHarness.kt # airbyte-integrations/connectors/destination-clickhouse/gradle.properties # airbyte-integrations/connectors/destination-snowflake/gradle.properties # airbyte-integrations/connectors/destination-snowflake/src/main/kotlin/io/airbyte/integrations/destination/snowflake/client/SnowflakeAirbyteClient.kt
…upsert_tests/connectors
…upsert_tests/connectors
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # ClickHouse | ||
|
|
||
| A fresh implementation of ClickHouse leveraging our new CDK. | ||
| A fresh implementation of ClickHouse leveraging our new CDK. |
Contributor
There was a problem hiding this comment.
[Google.We] Try to avoid using first-person plural like 'our'.
Contributor
There was a problem hiding this comment.
[markdownlint-fix] reported by reviewdog 🐶
airbyte/docs/integrations/destinations/clickhouse.md
Lines 6 to 9 in 846d001
Contributor
|
Note Detected that there are differences in the Gradle dependencies. |
Contributor
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 846d001. |
Edward Gao (edgao)
deleted the
edgao/component_upsert_tests/connectors
branch
October 29, 2025 15:53
Francis Genet (frifriSF59)
pushed a commit
that referenced
this pull request
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Connectors half of part 2 of https://github.com/airbytehq/airbyte-internal-issues/issues/14865. Branched from #68185.
How
Mostly just minor tweaks. Crucially, make snowflake's readTable method read timestamptz/array/object/variant in the way that the expected records expect.
Technically: we could make the snowflake tests declare a different set of expected records? But that feels really annoying, given that I want to change the input records at some point https://github.com/airbytehq/airbyte-internal-issues/issues/14910
(the readTable changes also just seem pretty reasonable, i.e. read an iso8601 timestamp instead of whatever snowflake does by default; read unstructured types into a map/list/etc. instead of leaving them as string)
Review guide
As usual, review each commit in sequence.
Can this PR be safely reverted and rolled back?