Skip to content

πŸ› Source Salesforce: Fix types for anyType fields - #7778

Merged
Yevhenii (yevhenii-ldv) merged 4 commits into
masterfrom
ykurochkin/fix-types-for-anyTypes-fields
Nov 9, 2021
Merged

πŸ› Source Salesforce: Fix types for anyType fields#7778
Yevhenii (yevhenii-ldv) merged 4 commits into
masterfrom
ykurochkin/fix-types-for-anyTypes-fields

Conversation

@yevhenii-ldv

Copy link
Copy Markdown
Contributor

What

resolves #6886.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yevhenii-ldv

Yevhenii (yevhenii-ldv) commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

πŸ•‘ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439091057
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439091057
πŸ› https://gradle.com/s/aphrimetou4hq

@github-actions github-actions Bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 9, 2021
@yevhenii-ldv
Yevhenii (yevhenii-ldv) temporarily deployed to more-secrets November 9, 2021 10:48 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 9, 2021 10:50 Inactive
@yevhenii-ldv

Yevhenii (yevhenii-ldv) commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

πŸ•‘ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439135777
βœ… connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439135777
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 Name                                 Stmts   Miss  Cover/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-salesforce/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 source_salesforce/__init__.py            2      2     0%
	 source_salesforce/api.py               114    114     0%
	 source_salesforce/exceptions.py          1      1     0%
	 source_salesforce/rate_limiting.py      22     22     0%
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_salesforce/source.py             52     52     0%
	 source_salesforce/streams.py           201    201     0%
	 --------------------------------------------------------
	 TOTAL                                  392    392     0%

@yevhenii-ldv
Yevhenii (yevhenii-ldv) temporarily deployed to more-secrets November 9, 2021 11:02 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 9, 2021 11:03 Inactive
@yevhenii-ldv

Yevhenii (yevhenii-ldv) commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-salesforce

πŸ•‘ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439752984
βœ… connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1439752984

@yevhenii-ldv
Yevhenii (yevhenii-ldv) temporarily deployed to more-secrets November 9, 2021 13:53 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 9, 2021 13:54 Inactive
@yevhenii-ldv
Yevhenii (yevhenii-ldv) merged commit 3d4f730 into master Nov 9, 2021
@yevhenii-ldv
Yevhenii (yevhenii-ldv) deleted the ykurochkin/fix-types-for-anyTypes-fields branch November 9, 2021 14:08
Konrad Schlatte (schlattk) pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source Salesforce: NewValue and OldValue columns are not getting pulled for OpportunityFieldHistory

4 participants