:bug: Source MySQL: transform binary data base64 format by mkhokh-33 · Pull Request #8047 · airbytehq/airbyte

mkhokh-33 · 2021-11-17T11:26:07Z

What

MySql source handle binary data as base64 encoded string, fixed integrations data type tests
Fixed cdc handling of binary data as base64 encoded string and cdc integrations data type
Provide additional properties in JSON schema for binary data
Added tests to check how BinaryNode will be serialized

How

Configured MySqlCdcProperties with binary.handling.mode = base64 to make sure that binary data represented as a base64-encoded String

🚨 User Impact 🚨

For AirbyteStream in jsonShema will appear new additional property contentEncoding:
jsonSchema={"type":"object","properties":{"name":{"type":"string","contentEncoding":"base64"},"id":{"type":"string"}}}
as far as I see - https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/bases/base-normalization/normalization/transform_catalog/stream_processor.py#L483
it should not affect how binary data will be represented in destination with normalization

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2021-11-17T11:26:14Z

All committers have signed the CLA.

mkhokh-33 · 2021-11-17T11:34:04Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1471358695
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1471358695
No Python unittests run

VitaliiMaltsev · 2021-11-18T12:01:20Z

-  BOOLEAN,
-  NULL;
+
+  STRING_BINARY(ImmutableMap.of("type", "string", "contentEncoding", "base64")),


Liren Tu (@tuliren) can we use JsonSchemaPrimitive as is in scope of this PR or better wait until #7944 will be implemented?

Yes, I think the current implementation looks good.

mkhokh-33 · 2021-11-19T09:58:39Z

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480466761
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480466761
No Python unittests run

mkhokh-33 · 2021-11-19T10:34:18Z

/publish connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1480592021
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1480592021

mkhokh-33 · 2021-11-19T10:34:49Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480593657
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480593657

mkhokh-33 · 2021-11-19T14:50:11Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1481475756
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1481475756
No Python unittests run

mkhokh-33 · 2021-11-22T13:41:59Z

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1490443738
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1490443738
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

mkhokh-33 · 2021-11-22T14:13:28Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1490572686
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1490572686
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

…bstractTest

mkhokh-33 · 2021-11-22T19:49:04Z

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1491866210
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1491866210
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

mkhokh-33 · 2021-11-22T19:49:25Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1491867113
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1491867113
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

mkhokh-33 · 2021-11-22T19:51:02Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1491871899
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1491871899
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

mkhokh-33 · 2021-11-22T19:53:12Z

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1491878254
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1491878254
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

mkhokh-33 · 2021-11-22T19:53:54Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1491880204
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1491880204
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

* Source-MySql: transform binary data base64 format, add integration tests * Source-MySql: fix code style * Source-MySql: bump versions * Source-MySql: bump versions in source_specs.yaml * Source-MySql: added test for stream with binary data for DestinationAbstractTest * Source-MySql: added format

Source-MySql: transform binary data base64 format, add integration tests

7f1a91d

github-actions Bot added area/connectors Connector related issues area/platform issues related to the platform area/protocol labels Nov 17, 2021

mkhokh-33 temporarily deployed to more-secrets November 17, 2021 11:27 Inactive

mkhokh-33 changed the title ~~Source-MySql: transform binary data base64 format, add integration tests~~ 🐛 Source MySQL: transform binary data base64 format Nov 17, 2021

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 17, 2021 11:36 Inactive

Source-MySql: fix code style

52d8588

mkhokh-33 temporarily deployed to more-secrets November 17, 2021 11:57 Inactive

mkhokh-33 requested review from Andrii Leonets (DoNotPanicUA), VitaliiMaltsev and oneshcheret (sashaNeshcheret) November 17, 2021 12:56

mkhokh-33 temporarily deployed to more-secrets November 17, 2021 13:33 Inactive

mkhokh-33 temporarily deployed to more-secrets November 17, 2021 14:05 Inactive

mkhokh-33 linked an issue Nov 17, 2021 that may be closed by this pull request

MySql source : source binary node transforms to text node #5878

Closed

VitaliiMaltsev reviewed Nov 18, 2021

View reviewed changes

Liren Tu (tuliren) approved these changes Nov 19, 2021

View reviewed changes

VitaliiMaltsev approved these changes Nov 19, 2021

View reviewed changes

Andrii Leonets (DoNotPanicUA) approved these changes Nov 19, 2021

View reviewed changes

mkhokh-33 marked this pull request as ready for review November 19, 2021 09:51

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 19, 2021 10:01 Inactive

Source-MySql: bump versions

dfa865e

github-actions Bot added the area/documentation Improvements or additions to documentation label Nov 19, 2021

mkhokh-33 temporarily deployed to more-secrets November 19, 2021 10:15 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 19, 2021 10:36 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 19, 2021 12:42 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 19, 2021 14:52 Inactive

oneshcheret (sashaNeshcheret) approved these changes Nov 22, 2021

View reviewed changes

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 22, 2021 13:44 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 22, 2021 14:15 Inactive

Source-MySql: added test for stream with binary data for DestinationA…

be4f7f2

…bstractTest

mkhokh-33 temporarily deployed to more-secrets November 22, 2021 17:56 Inactive

mkhokh-33 temporarily deployed to more-secrets November 22, 2021 19:03 Inactive

Source-MySql: added format

1070073

mkhokh-33 temporarily deployed to more-secrets November 22, 2021 19:17 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 22, 2021 19:51 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 22, 2021 19:53 Inactive

Jared Rhizor (jrhizor) temporarily deployed to more-secrets November 22, 2021 19:55 Inactive

mkhokh-33 merged commit 5032add into master Nov 23, 2021

mkhokh-33 deleted the mkhokh/5878-binary-data-mysql-source branch November 23, 2021 14:04

Karina Kuznietsova (karinakuz) added connectors/sources-database connectors/source/cockroachdb-strict-encrypt labels Jan 4, 2022

Karina Kuznietsova (karinakuz) added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 18, 2022

Uh oh!

Conversation

mkhokh-33 commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Uh oh!

CLAassistant commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 17, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VitaliiMaltsev Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

Liren Tu (tuliren) Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

mkhokh-33 commented Nov 19, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 19, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 19, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 19, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhokh-33 commented Nov 22, 2021 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mkhokh-33 commented Nov 17, 2021 •

edited

Loading

CLAassistant commented Nov 17, 2021 •

edited

Loading

mkhokh-33 commented Nov 17, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 19, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 19, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 19, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 19, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading

mkhokh-33 commented Nov 22, 2021 •

edited by github-actions Bot

Loading