Skip to content

🐛 Source Salesforce: 400 error for non-queryable streams - #9005

Merged
Maksym Pavlenok (antixar) merged 22 commits into
masterfrom
antixar/61-oncall-salesforce-400-error
Dec 23, 2021
Merged

🐛 Source Salesforce: 400 error for non-queryable streams#9005
Maksym Pavlenok (antixar) merged 22 commits into
masterfrom
antixar/61-oncall-salesforce-400-error

Conversation

@antixar

@antixar Maksym Pavlenok (antixar) commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

What

oncall/61
This issue is similar with this
A set of stream can't be called directly. For them the BULK API should return a custom error message.

How

Hook this error message and skip that stream.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions Bot added the area/connectors Connector related issues label Dec 21, 2021
@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 21, 2021 16:32 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 21, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1607728133
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1607728133
🐛 https://gradle.com/s/szw7lqctc2ic4

@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 21, 2021 16:35 Inactive
@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 21, 2021 16:38 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 21, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1607772860
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1607772860
🐛 https://gradle.com/s/pe4av6wgbfryq
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - jsonschema.exce...
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestDiscovery.test_discover because not found in the config
============== 3 failed, 7 passed, 1 skipped, 8 errors in 12.02s ===============

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 21, 2021 16:46 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 21, 2021 16:47 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 21, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1609083743
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1609083743
🐛 https://gradle.com/s/6jbdq443bgfva

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 21, 2021 23:26 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 21, 2021 23:27 Inactive
sherifnada
Sherif A. Nada (sherifnada) reviewed Dec 22, 2021
View reviewed changes

@sherifnada Sherif A. Nada (sherifnada) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the stream is not directly queryable, how is it queried? is through another stream?

Comment thread airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py
@antixar

Maksym Pavlenok (antixar) commented Dec 22, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1611975509
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1611975509
🐛 https://gradle.com/s/dt6q46ym36rzo
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - jsonschema.exce...
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestDiscovery.test_discover because not found in the config
============== 3 failed, 7 passed, 1 skipped, 8 errors in 12.42s ===============

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1611975509
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1611975509
🐛

@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 22, 2021 15:37 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 22, 2021 18:24 Inactive
@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021
@antixar

Maksym Pavlenok (antixar) commented Dec 22, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613327617
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613327617
🐛

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 22, 2021 22:45 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 22, 2021 22:45 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 22, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613362646
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613362646
🐛

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 22, 2021 23:00 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 22, 2021 23:00 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 22, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613420228
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613420228
🐛

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 22, 2021 23:21 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 22, 2021 23:21 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 23, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613538322
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613538322
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               121     17    86%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             57     20    65%
	 source_salesforce/streams.py           219    127    42%
	 --------------------------------------------------------
	 TOTAL                                  422    170    60%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               121     62    49%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             57     24    58%
	 source_salesforce/streams.py           219     39    82%
	 --------------------------------------------------------
	 TOTAL                                  422    131    69%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestDiscovery.test_discover because not found in the config
================== 18 passed, 1 skipped in 261.39s (0:04:21) ===================

@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 23, 2021 00:09 Inactive
@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 23, 2021 00:10 Inactive
@antixar

Maksym Pavlenok (antixar) commented Dec 23, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613577897
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1613577897

@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets December 23, 2021 00:25 Inactive
@antixar
Maksym Pavlenok (antixar) temporarily deployed to more-secrets December 23, 2021 00:41 Inactive
@antixar
Maksym Pavlenok (antixar) merged commit a4be492 into master Dec 23, 2021
@antixar
Maksym Pavlenok (antixar) deleted the antixar/61-oncall-salesforce-400-error branch December 23, 2021 00:42
@jrhizor Jared Rhizor (jrhizor) mentioned this pull request Dec 27, 2021
Merged

This branch was previously deployed

1 inactive deployment
more-secrets — 64b5deb7 Deployed Dec 23, 2021 by antixar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sherifnada Sherif A. Nada (sherifnada) sherifnada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@antixar Maksym Pavlenok (antixar)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antixar @sherifnada @jrhizor