Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCMP Decryption QoS #858

Closed
aircrack-ng opened this issue Mar 10, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@aircrack-ng
Copy link
Owner

commented Mar 10, 2018

Reported by Alex Iliadis on 21 Mar 2011 15:55 UTC

It has come to my attention that crypto.c:decrypt_ccmp does not check if the packet is of subtype QoS DATA. This results into the wrong offsets being set (more specifically z) which renders the decryption in airdecap-ng to be broken. The solution to this would be to modify ccmp_decrypt as defined in crypto.c to increment z by 2 if it's of QoS type.

After line 1152 z would need the following:


if (GET_SUBTYPE(h80211[0])==IEEE80211_FC0_SUBTYPE_QOS)
z += 2;


Hope this helps.

@aircrack-ng aircrack-ng added this to the 1.3 milestone Mar 10, 2018

@aircrack-ng

This comment has been minimized.

Copy link
Owner Author

commented Mar 10, 2018

Comment by misterx on 21 Mar 2011 15:55 UTC

Looks similar to #667

@aircrack-ng

This comment has been minimized.

Copy link
Owner Author

commented Mar 10, 2018

Comment by misterx on 21 Mar 2011 15:55 UTC

Fixed by 52a8d79.

@aircrack-ng aircrack-ng modified the milestones: 1.3, 1.2 Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.