Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck finds quite a few issues on the code #957

Closed
aircrack-ng opened this issue Mar 10, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@aircrack-ng
Copy link
Owner

commented Mar 10, 2018

Reported by Carlos Lopez clopez on 3 Dec 2011 17:52 UTC

cppcheck finds quite a few issues:

[(error) Memory leak: ivs_table
[src/airodump-ng.c:6353](src/airdecloak-ng.c:1128]:): (error) Possible null pointer dereference: ap_cur - otherwise it is redundant to check if ap_cur is null at line 6355
[(error) Possible null pointer dereference: ap_cur - otherwise it is redundant to check if ap_cur is null at line 325
[src/airtun-ng.c:677](src/aircrack-ng.c:323]:): (error) Resource leak: f
[(error) Resource leak: f
[src/kstats.c:328](src/airbase-ng.c:1457]:): (error) Resource leak: f
[(error) Memory leak: ivbuf
[src/ivstools.c:168](src/kstats.c:322]:): (error) Resource leak: f_in
[(error) Resource leak: f_out
[src/ivstools.c:814](src/ivstools.c:162]:): (error) Resource leak: f_in
[(error) Resource leak: f_cap_out
[src/aireplay-ng.c:1162](src/aireplay-ng.c:1107]:): (error) Resource leak: f
[(error) Memory leak: key
[src/osdep/linux.c:956](src/aircrack-ng.c:4392]:): (error) Resource leak: fd2
[(error) Resource leak: fp
[src/osdep/linux.c:2074](src/airodump-ng.c:401]:): (error) Resource leak: apm
[(error) Memory leak: uiv_lvl2
[src/tkiptun-ng.c:1326](src/uniqueiv.c:117]:): (error) Resource leak: f_cap_out
[(error) Resource leak: f
[src/sha1-sse2.h:72](src/tkiptun-ng.c:1381]:): (error) Dangerous usage of 'essid' (strncpy doesn't always 0-terminate it)
[src/sha1-sse2.h:80]: (error) Dangerous usage of 'key1' (strncpy doesn't always 0-terminate it)

''http:''//''bugs.debian.org/cgi-bin/bugreport.cgi?bug=642934''

@aircrack-ng

This comment has been minimized.

Copy link
Owner Author

commented Mar 10, 2018

Comment by misterx on 3 Dec 2011 17:52 UTC

cppcheck is wrong for quite a few things.

@aircrack-ng aircrack-ng added this to the 1.2 milestone Mar 10, 2018

@aircrack-ng

This comment has been minimized.

Copy link
Owner Author

commented Mar 10, 2018

Comment by misterx on 3 Dec 2011 17:52 UTC

Fixed in a33074e.

@aircrack-ng aircrack-ng added @medium and removed @major labels Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.