New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with mmx #1943

Merged
merged 1 commit into from Aug 27, 2018

Conversation

5 participants
@ffontaine
Contributor

ffontaine commented Aug 22, 2018

Commit 39387fc removed mmx support
however aircrack-ng fails to build on platforms with mmx because an
error is raised if MMX is defined.

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Fix build with mmx
Commit 39387fc removed mmx support
however aircrack-ng fails to build on platforms with mmx because an
error is raised if __MMX__ is defined.

Fixes:
 - http://autobuild.buildroot.net/results/b7362b69435e9ef6fb2aedc50743e88dbd7a5c72

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 22, 2018

Coverage Status

Coverage increased (+0.01%) to 37.959% when pulling 37078a4 on ffontaine:master into 91ea647 on aircrack-ng:master.

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+0.01%) to 37.959% when pulling 37078a4 on ffontaine:master into 91ea647 on aircrack-ng:master.

@aircrack-ng

This comment has been minimized.

Show comment
Hide comment
@aircrack-ng

aircrack-ng Aug 25, 2018

Owner

Is there any currently supported Linux distribution that still handles such CPU, assuming it's using P5 microarchitecture (based on the toolchain being 586)?

Owner

aircrack-ng commented Aug 25, 2018

Is there any currently supported Linux distribution that still handles such CPU, assuming it's using P5 microarchitecture (based on the toolchain being 586)?

@ffontaine

This comment has been minimized.

Show comment
Hide comment
@ffontaine

ffontaine Aug 26, 2018

Contributor

This toolchain is still in the buildroot's autobuilders (http://autobuild.buildroot.net/toolchains/tarballs/br-i386-pentium-mmx-musl-2018.05.tar.bz2) but I suppose there is not a lot of users.

If you don't like removing this code from aircrack-ng, an other option would be disable aircrack-ng on CPUs with MMU support.

Contributor

ffontaine commented Aug 26, 2018

This toolchain is still in the buildroot's autobuilders (http://autobuild.buildroot.net/toolchains/tarballs/br-i386-pentium-mmx-musl-2018.05.tar.bz2) but I suppose there is not a lot of users.

If you don't like removing this code from aircrack-ng, an other option would be disable aircrack-ng on CPUs with MMU support.

@aircrack-ng

This comment has been minimized.

Show comment
Hide comment
@aircrack-ng

aircrack-ng Aug 27, 2018

Owner

It compiles and runs on FreeBSD on a Pentium MMX. The only SIMD that works is 'generic'.

I'd love to see a use case for such toolchain though.

Owner

aircrack-ng commented Aug 27, 2018

It compiles and runs on FreeBSD on a Pentium MMX. The only SIMD that works is 'generic'.

I'd love to see a use case for such toolchain though.

@ZeroChaos-

This comment has been minimized.

Show comment
Hide comment
@ZeroChaos-

ZeroChaos- Aug 27, 2018

Collaborator

gentoo officially supports i386, i486, and i586

Collaborator

ZeroChaos- commented Aug 27, 2018

gentoo officially supports i386, i486, and i586

@aircrack-ng

This comment has been minimized.

Show comment
Hide comment
@aircrack-ng

aircrack-ng Aug 27, 2018

Owner

Is there any good tutorial on setting up a i586 version?

Owner

aircrack-ng commented Aug 27, 2018

Is there any good tutorial on setting up a i586 version?

@jbenden jbenden merged commit 4e7cf51 into aircrack-ng:master Aug 27, 2018

10 checks passed

buildbot/aircrack-ng Build done.
Details
buildbot/aircrack-ng-alpine Build done.
Details
buildbot/aircrack-ng-armel Build done.
Details
buildbot/aircrack-ng-armhf Build done.
Details
buildbot/aircrack-ng-bsd Build done.
Details
buildbot/aircrack-ng-centos Build done.
Details
buildbot/aircrack-ng-kali Build done.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 37.959%
Details
@jbenden

This comment has been minimized.

Show comment
Hide comment
@jbenden

jbenden Aug 27, 2018

Collaborator

I've accepted the patch, as-is, because it shouldn't have failed to build; it should have just built a generic binary.

Thanks!
-Joe

Collaborator

jbenden commented Aug 27, 2018

I've accepted the patch, as-is, because it shouldn't have failed to build; it should have just built a generic binary.

Thanks!
-Joe

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this pull request Aug 27, 2018

aircrack-ng: fix build with mmx
Commit 39387fc80f90f3a9ac9ef9f3aa32da5776a0721e removed mmx support
however aircrack-ng fails to build on platforms with mmx because an
error is raised if __MMX__ is defined.

Fixes:
 - http://autobuild.buildroot.net/results/b7362b69435e9ef6fb2aedc50743e88dbd7a5c72

[Upstream status: merged
(aircrack-ng/aircrack-ng#1943)]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

snickl added a commit to snickl/buildroot that referenced this pull request Oct 7, 2018

aircrack-ng: fix build with mmx
Commit 39387fc80f90f3a9ac9ef9f3aa32da5776a0721e removed mmx support
however aircrack-ng fails to build on platforms with mmx because an
error is raised if __MMX__ is defined.

Fixes:
 - http://autobuild.buildroot.net/results/b7362b69435e9ef6fb2aedc50743e88dbd7a5c72

[Upstream status: merged
(aircrack-ng/aircrack-ng#1943)]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment