Build using `-pedantic`; in Autoconf maintainer mode #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jbenden merged 66 commits into aircrack-ng:master from jbenden:jbenden/pedantic

Oct 31, 2020

Collaborator

jbenden commented Aug 18, 2020 •

edited

Loading

This patch series goes through the source code to enable builds, without warnings or errors, under the strictness of -pedantic compiler flag. Additionally, some of the shell scripts were fixed with shellcheck.

This patch series introduces the selection of a C++ standard (non-required) to assess the availability across the CI infrastructure.

This patch series fixes the great majority of outstanding PVS-Studio warnings.

Finally, and most important for other developers, is that we all must enable maintainer mode during our development; pass --enable-maintainer-mode to the configure script. This Autoconf flag is what enables the -pedantic warnings.

Owner

aircrack-ng commented Aug 24, 2020

Could you document the new configure flag (--enable-maintainer-mode) in README.md and INSTALLING?

Could you update the case of PCRE to make it uppercase in besside-ng usage?

Collaborator Author

jbenden commented Aug 24, 2020 via email

On 8/23/20 5:15 PM, Aircrack-ng wrote: Could you document the new configure flag (|--enable-maintainer-mode|) in README.md and INSTALLING? Could you update the case of PCRE to make it uppercase in besside-ng usage? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2174 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASAJ6UFUVACRCJRVI3QQDSCGWK7ANCNFSM4QD6KITA>.

I have just published additional commits which tackle these items. Let me know if I missed something. Suggestions, comments, and ideas are always welcomed, -Joe

jbenden added 24 commits

September 1, 2020 16:18


          fix(ce-wpa): anonymous unions are a C11 extension

b97e05b

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor: fix undefined behaviour

d06cb03

This removes the use of macros within strings. This is an undefined
usage. Instead, simply print all possible command-line arguments and
show an error message if an unsupported option is selected.

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor: fix function callback types

48fabd1

- Callbacks should be passed as the address-of a function.
- Mark all thread routines with THREAD_ENTRY to make it very
  clear that these function run in a new thread.

Signed-off-by: Joseph Benden <joe@benden.us>


          airodump-ng: binary constants are a gnu extension

5edf114

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor: use c99-style

a42329a

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor: use of \e is a gnu extension

e223e9d

Signed-off-by: Joseph Benden <joe@benden.us>


          unit-tests: must have cast to clean compile

8968ce4

Signed-off-by: Joseph Benden <joe@benden.us>


          unit-tests: conversion to constant expr is a gcc extension

bebf1a9

Signed-off-by: Joseph Benden <joe@benden.us>


          mark gcc specific: braced-group within expression

3ecf8dc

Signed-off-by: Joseph Benden <joe@benden.us>


          fix scanf formats expecting unsigned int

336bf8c

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: refactor maintainer mode

af98fcc

- Disable maintainer mode, by default. Now use the flag
  `--enable-maintainer-mode` when developing both autoconf
  and source code!
- When maintainer mode is enabled; add pedantic warnings.

Signed-off-by: Joseph Benden <joe@benden.us>


          fixed all shellcheck reported warnings

74a2b69

Signed-off-by: Joseph Benden <joe@benden.us>


          re-ran clang-format-3.8 over sources

Signed-off-by: Joseph Benden <joe@benden.us>


          remove loop unrolls

83e32a7

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor(ce-wpa): spring clean formulas

7a6a53f

Signed-off-by: Joseph Benden <joe@benden.us>


          aircrack-ng: fix incorrect usage of phread_mutex_trylock

d83cadd

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: Check for modern C++ support

40ded69

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: reduce build noise

69489f1

Signed-off-by: Joseph Benden <joe@benden.us>


          besside-ng: re-format source code

625a8ff

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: initial support for LTO builds

This patch series untangles the mixed assembly syntax, thereby
removing the need for `-masm=intel`.

Added autoconf flag to enable LTO: `--with-lto`.

As this is basic support (works for me! :P), it is not enabled
by default.

Signed-off-by: Joseph Benden <joe@benden.us>


          Updated the case of PCRE in usages and errors.

65d3757

Signed-off-by: Joseph Benden <joe@benden.us>


          Document the --enable-maintainer-mode configure flag

aec1faa

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(lib/libac): add cache-line padding around fields

518d7e2

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(airodump-ng): fix crash on 4K Linux console

11aa988

Signed-off-by: Joseph Benden <joe@benden.us>

jbenden force-pushed the jbenden/pedantic branch from 6b3413f to 11aa988 Compare

September 1, 2020 23:33

jbenden added 3 commits

September 2, 2020 13:48


          simplify code; add validation of port number

7df9192

Signed-off-by: Joseph Benden <joe@benden.us>


          add PVS-Studio suppressions for DbC macros

4c32d41

Signed-off-by: Joseph Benden <joe@benden.us>


          many type fixes

91ae695

Signed-off-by: Joseph Benden <joe@benden.us>

jbenden added 17 commits

September 11, 2020 12:15


          fix type and initialization issues

f4629eb

Signed-off-by: Joseph Benden <joe@benden.us>


          add missing include header

070ba3c

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(osdep/netbsd_tap): fix size of buffer

f3cca90

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(tkiptun-ng): type fix

cdbacb8

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(airodump-ng): test explicitly against unsigned char

a358620

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(libac): DragonFlyBSD uses special include for *_np

f9c86a9

Signed-off-by: Joseph Benden <joe@benden.us>


          type cannot be negative

e52320d

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: do not enable -Werror with icc

20e873c

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(aircrack-ng): fix return value

084f421

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(airventriloquist-ng): change case expression to a block

f8dc139

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: enable -pedantic when GCC v4.9 or later

2d21b60

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor: create a fallthrough macro

4da7289

Signed-off-by: Joseph Benden <joe@benden.us>


          refactor(aircrack-ng): adjust inlining

3af47cc

- Thread entry functions must never be inlined.
- Mark certain functions as noinline, based on ICC optimization
  reports.

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: disable ICC remark reporting

3d5e898

This commit is to keep ICC from reporting remarks about inlining.

Signed-off-by: Joseph Benden <joe@benden.us>


          tests: remove non-standard preprocessor directive

c16e9b1

Signed-off-by: Joseph Benden <joe@benden.us>


          unittests: change usage to prevent -pedantic error

dc61a2f

Signed-off-by: Joseph Benden <joe@benden.us>


          autotools: do not complain about zero variadic macro args

757d155

Signed-off-by: Joseph Benden <joe@benden.us>

jbenden force-pushed the jbenden/pedantic branch from 3b97a52 to 757d155 Compare

September 12, 2020 22:17

jbenden added 3 commits

September 12, 2020 16:33


          appveyor: always save cache and do not package PRs

553e9e6

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(aircrack-ng): validate user input for process count

a8cddc2

- Fully validate the number of processes desired (`-p`);
  ensuring a selection is made from a fully valid range.
  Fixes (CID 1077260)
- Display a warning message if the number of processes
  exceed the number of CPUs.

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(aireplay-ng): fix potential division-by-zero (CID 1077329)

faaaaa0

Signed-off-by: Joseph Benden <joe@benden.us>

jbenden force-pushed the jbenden/pedantic branch from 60ec9f4 to faaaaa0 Compare

September 21, 2020 04:27

jbenden added 6 commits

October 9, 2020 11:55


          fix(osdep/cygwin): suppress dlsym errors

736f71a

See: https://stackoverflow.com/questions/36384195/how-to-correctly-assign-a-pointer-returned-by-dlsym-into-a-variable-of-function
Signed-off-by: Joseph Benden <joe@benden.us>


          appveyor: enable maintainer mode

d834739

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(build): fix compilation with -DNDEBUG

8e24bf2

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(osdep/cygwin_tap): fix mismatched signed comparisons

02fff55

Signed-off-by: Joseph Benden <joe@benden.us>


          fix(osdep/airpcap): exclude header file from pedantic

a4c6c63

Signed-off-by: Joseph Benden <joe@benden.us>


          fix unmarked fall-through branches

Signed-off-by: Joseph Benden <joe@benden.us>

jbenden self-assigned this

jbenden merged commit d0a0f9d into aircrack-ng:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet