fix(besside-ng): bad beacon error

[ParadoxInfinite]

The initial value for buf was 2048 in

aircrack-ng/src/besside-ng/besside-ng.c

Line 2612 in 8e55278

unsigned char buf[2048];

However, in b8828cb, it was changed to

aircrack-ng/src/besside-ng/besside-ng.c

Line 2606 in b8828cb

unsigned char buf[sizeof(struct ieee80211_frame) * 8];

This causes the check if (totlen < l) goto __bad; in line 1848 of besside-ng.c become true as totlen is derived from the sizeof(*wh), which in turn is dependent on buf.

The size of ieee80211_frame is 24, so 24 * 32 still only results in 768, not 2048. I've tested this to be working with * 16 as well, but as a tradeoff between future possibility and memory conservation, I settled on 32.

Let me know if I should increase/decrease the value.

---

Fixes: #2268

Fixes: #2203

[ParadoxInfinite]

@aircrack-ng Hey, sorry for the ping, but could you take a look at this please? I think there are a couple of other places where the memory allocation could be lower(causing bad beacon issue, but this is the major one), I'll update them as well if this looks good. What do you think would be the right value?

[ParadoxInfinite]

@jbenden could you have a look at this maybe? It's a 1 line change but would save some issues being raised about bad beacon. I will rebase to the current master branch and also make changes if needed. Let me know, thanks!

[d3k4-k3rb3r0s]

Still having this issue, June 2023, edited the besside-ng.c file manually even, fresh install.. nothing