Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8812au_xmit.c : Compiler warns that conditional will always be false #308

Closed
rickhg12hs opened this issue Mar 30, 2019 · 1 comment
Closed

rtl8812au_xmit.c : Compiler warns that conditional will always be false #308

rickhg12hs opened this issue Mar 30, 2019 · 1 comment

Comments

@rickhg12hs
Copy link

Current code that causes warning:

rtl8812au/hal/rtl8812a/usb/rtl8812au_xmit.c

Line 445 in 1ae2f32

while ((rtw_read32(adapter, REG_PKTBUF_DBG_CTRL) & BIT23) == 1) {

Maybe this should be:

while ((rtw_read32(adapter, REG_PKTBUF_DBG_CTRL) & BIT23) != 0) {

... or some other test to see if the bit is set?
@kimocoder
Copy link
Collaborator

Thanks, the fix has been applied to the v5.3.4 branch. 🥇

@paroque28 paroque28 mentioned this issue Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimocoder @rickhg12hs