Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character not supported ":" #246

Closed
Ayrler opened this Issue Jun 17, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Ayrler
Copy link

Ayrler commented Jun 17, 2017

Current UI and client versions:

AirDC++w 2.1.0 x86_64
Web UI version 2.1.0
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

Operating system:

Debian Linux 8

Steps to reproduce the issue:

Create a folder and choose a name containing the character ":"
E.g: DanMachi:Sword.Oratoria.S01 is replaced by DanMachi_Sword.Oratoria.S01

maksis added a commit to airdcpp/airgit that referenced this issue Jun 18, 2017

@maksis

This comment has been minimized.

Copy link
Collaborator

maksis commented Jun 18, 2017

This will be possible in the next version. However, I wouldn't recommend using colon in shared file/directory names as it's a reserved character on various operating systems (e.g. Windows and macOS).

@maksis maksis closed this Jun 18, 2017

maksis added a commit that referenced this issue Jun 23, 2017

Squashed 'airdcpp-core/' changes from fda82ce74..27f6ccc9b
27f6ccc9b Fix another throw clause
60ed05464 Remove deprecated exception specifiers
b4b5f1fc5 Filelists: validate filenames loaded from XML, path handling fixes
4c6fcd0f6 Use ADC path format internally (search, filelists)
598db61e1 Don't sanitize colons from file paths on Linux (#246)

git-subtree-dir: airdcpp-core
git-subtree-split: 27f6ccc9bcb582419c8e2138fecd7a29d94da91a

@maksis maksis added this to the 2.1.1 milestone Jul 8, 2017

maksis added a commit to airdcpp/airgit that referenced this issue Mar 4, 2018

Squashed 'airdcpp/' changes from 7a6a1bc..5161e3f
5161e3f Replace the deprecated GeoIP library with libmaxminddb
8763d04 Merge commit 'e6068897735ed64a1cb58e1446978625e44668ee' into develop
be28de4 Merge branch 'master' of github.com:airdcpp/airgit
cf2ccf5 Update copyright year
5c59c26 GeoIP: use localized language names (when possible)
47cc8fa Migrate GeoIP functions to use maxminddb
f9e4258 Merge commit 'a12ca973846276d4dfb15097d1330aab8f766f84' into develop
8f862bc Remove the setting "Don't begin new segment if overall file speed is over X"
07fb876 Merge commit '22bdaeda6637b66c1fb15bd6cc15bc2bab3bf280' into develop
5bfbce3 Add hubNI logging param for transfers (airdcpp-web/airdcpp-webclient#260)
2d5a391 pvs-studio fix V808 'su' object of 'basic_string' type was created but was not utilized. adchub.cpp 880 V808 'targets' object of 'vector' type was created but was not utilized. downloadmanager.cpp 73 V808 'hubIpPort' object of 'basic_string' type was created but was not utilized. uploadmanager.cpp 593 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function loadKeyprint. cryptomanager.cpp 490 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function toInt64. magnet.cpp 64 V611 The memory was allocated using 'new T[]' operator but was released using the 'delete' operator. Consider inspecting this code. It's probably better to use 'delete [] test;'. players.cpp 241 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 135 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 148 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function createSubMenu. downloadbasehandler.h 182 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 184 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 188 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 203 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. downloadbasehandler.h 229 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting second argument of the function MessageBoxConfirm. richtextbox.cpp 1129 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function createSubMenu. mainfrm.cpp 2029 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. mainfrm.cpp 2033 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. mainfrm.cpp 2036 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting second argument of the function MessageBoxConfirm. systemframe.cpp 443 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting first argument of the function appendItem. winutil.cpp 1473
7dacb53 Merge pull request #27 from pavel-pimenov/pvs-studio-fix-19-11-2017
4266d1a Merge pull request #28 from pavel-pimenov/fix-v1001-19-11-2017
956f055 V817 It is more efficient to seek ' ' character rather than a string.
daec18d Fix V1001 The 'size_' variable is assigned but is not used until the end of the function.
eecc6b9 pvs-studio fix
d3631aa Cleanup
3d2c135 Cleanup
ed1a2db Merge commit 'ebc92bb5b8090408e07940ae488d056117f9d783' into develop
0377c52 Use CommandHandler for dispatching ADC commands received via UDP
dd239a7 AdcCommand: use noexcept, allow passing additional arguments to command dispatchers
a1e59ec Don't add newly added shared directories for monitoring if monitoring is disabled for them
16ab1c6 Merge commit 'a57af306f4d25374d5789ff94ac6cc873db45b38' into develop
4643d4b new -> make_unique
ab69479 Default outgoing search path to ADC root
98f490d Bump the required GCC version to 4.9
64c5eda Use /permissive- switch with core and webapi to catch compiling issues affecting GCC/clang
511b969 ADL search: use NMDC path format for matching to maintain compatibility with old config files
40bdf5c Hubsoft warning updates
a6d77a6 Use UTF-8 - system charset conversions on Windows again
b3dd824 Merge commit '6c6c137b389bc86210f211299b2685ddb557e3ad' into develop
a507e5d Merge commit 'd488b01f59f6ece6e70a8c183d8848b4d8c8c11c' into develop
b5c95fb Fix Linux build
b7175ff Compiling fixes for Boost 1.65
5736401 Set Windows SDK version
2710b44 Require VS 2017.3 for compiling
1473da8 Merge commit 'e97f390dc697504f88f71fd2996ca9254100b952' into develop
89b0f28 Linux: drop support for non-UTF-8 system locales
6420d6c Report the unique file percentage correctly in share stats
64316e3 Merge commit '2f2770bcab3eb957c5605ce9965cdbb2ac96d50f' into develop
46aa8b7 Correct the file path validation
8d806cd Merge commit 'ce4620dcb617b9dd8390862d63ef9f14a252f7a4' into develop
8d9aa82 Proxy API setting fixes
4a82f08 Handle already open filelists in the UI
a72f413 Don't filter certain characters from filenames on non-Windows systems
20bb3af Ensure that the temp directory exists on startup (Windows only)
b44be35 Merge commit '48d0724acf967bb15e4a05331e556dea56521672' into develop
77960de ADL search: don't set empty directory names
3a8604d Remove path separators from ADL search directory names
7a7ab14 Merge commit 'b84f7f3b3aa4bb401952d827ae74198a073c4c1a' into develop
4eeb752 Fix a deprecation warning with OpenSSL 1.1.0
5ddcd8e Merge commit '2cbbde8e22ac56d86dbc554abc8542ed8828c2b4' into develop
27f6ccc Fix another throw clause
60ed054 Remove deprecated exception specifiers
b4b5f1f Filelists: validate filenames loaded from XML, path handling fixes
4c6fcd0 Use ADC path format internally (search, filelists)
598db61 Don't sanitize colons from file paths on Linux (airdcpp-web/airdcpp-webclient#246)
9129a28 Merge commit '113ce5c5df27596186c397b987b0265f19fa82ca' into develop
fda82ce Ignore messages regardless of the user levels (airdcpp-web/airdcpp-webclient#221)
5dc304f Improve case conversion performance, cleanup
88149d1 Merge commit 'de37ad2845a9698a4f3921f1e1d7cafce7ee69ab' into develop
846646a New share root validation cleanup
fb95c43 Merge branch 'develop' of github.com:airdcpp-web/airdcpp-webclient into develop
79cdf5e Use precompiled headers for compiling (cotire)
9196943 Merge commit 'fc7c1e159c313d7939bca059775dae17c76c19e0' into develop
a98dad8 Update hub hint when opening new filelists for offline hubs
4889797 Filelists: fix removal of QueueItem when closing the filelist if the initial download hasn't completed
eac4843 Filelists: set content info for loaded base paths
ac864e6 Merge commit '3c1acad2fc7a53cd455121893bbc3597eca97507' into develop
9ad0110 Change the default NMDC encoding to CP1252 on Linux
daffff1 Always hide hub identities from userlist (ADC)
68d0fd4 Link static builds against Snappy
1d00546 Merge commit 'e09bcc6a3019d844d090ff090160d076caf5efda' into develop
47d3da1 Add support for dcppboot.xml.user
f5ae8fd Cleanup
5ba66d2 Skip share scan for bundles that aren't in a shared directory
bf8a7d3 Merge commit '75d4204226a4d82cdf90fac0c0e1c1d63cca3fcd' into develop
60b4b58 Don't migrate old setting values on Linux
256c728 Fix share scanner
aec312f Merge commit '4f31b5d1add7f856ed4f282eec05979a552cfd75' into develop
d6c7229 Move GUI/module-specific paths out of Util
a2279cc Merge commit '87c14c7c9af978064bb563dab08e9758811fe49e' into develop
0c5c2e6 Don't add separators in directory FilesystemItem names
812039d Add File::moveDirectory and Util::joinDirectory
593b089 Merge commit '1e59569aa2e17d94b4173d4e5cae5fe5f13d1b4c' into develop
7ebbee4 Add SettingsManager::LoadCompleted listener that is fired even if no XML file existed
e1c1761 Merge branch 'master' of https://github.com/airdcpp/airgit
8b0b31b Disallow unencrypted CCPM connections
c260da5 Don't hit an assertion when removing bundles that don't exist in search queue
cdeeca4 Allow skipping the queue check when validating shared paths
50b5e1a Merge branch 'master' of https://github.com/airdcpp/airgit
340bd4c fix https://bugs.launchpad.net/airdcpp/+bug/1682205
8f08b3a Merge commit '19cf5842632f21f2910f1103a780ca58efddb514' into develop
e9a6bb9 Implement local config mode for Linux
a962471 Fix a build warning
b19e9de Add a missing define for debug mode
93458a7 Merge commit '40791b9f7c66fe4b36a82c02cf7bee7ebc2ded1d' into develop
07de84f Fix debug build on Linux
1dd6b86 Allow creating a static binary, misc build file fixes and cleanup
6c67a1b Add share validation hooks
327ee8c Make various ID counters thread safe
9459655 Don't uncapitalize the errors after all
4d5fd34 Rework error reporting for blocked share files
59b7ecc Run chat message hooks even when not being connected to the hub
d3d0889 Fix incorrect assertions
eda5095 auto search fix
da28d63 Disable window auto open options when using last state option
7c52e26 Prevent possible deadlocks when running DelayedEvent tasks
f7c9f18 Avoid double separators in rc menus
faba111 Merge branch 'master' of https://github.com/airdcpp/airgit
0bed2bc Increase per user slot limits for high connection speeds

git-subtree-dir: airdcpp
git-subtree-split: 5161e3f24d7f7cd507a0dece75744ab314466de4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.