New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle updates #170

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
4 participants
@electrum
Copy link
Member

electrum commented Dec 4, 2018

No description provided.

@electrum electrum requested a review from dain Dec 4, 2018

<property name="allowNoEmptyLineBetweenFields" value="true" />
<property name="tokens" value="
IMPORT, STATIC_IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF,
STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF" />

This comment has been minimized.

@martint

martint Dec 4, 2018

Member

What's the effect of VARIABLE_DEF here? Will it force a new line between all variable definitions?

This comment has been minimized.

@findepi

findepi Dec 4, 2018

Contributor

same for IMPORT and STATIC_IMPORT

This comment has been minimized.

@electrum

electrum Dec 4, 2018

Member

It seems to just be for fields. I ran it on the Airlift and Presto code bases and the checks passed. It also caught the things I expected it to catch.

This is the default list expect for “package”, which we can’t use since we don’t put a blank line after the copyright header.

@electrum electrum force-pushed the electrum:checkstyle branch from f239941 to 7ffae69 Dec 16, 2018

@electrum electrum force-pushed the electrum:checkstyle branch from 7ffae69 to a252a47 Dec 29, 2018

@dain

dain approved these changes Jan 3, 2019

Copy link
Member

dain left a comment

Looks good to me

@electrum electrum force-pushed the electrum:checkstyle branch from a252a47 to 6b1e4bc Jan 4, 2019

@electrum electrum force-pushed the electrum:checkstyle branch from 6b1e4bc to 584c2bd Jan 4, 2019

@electrum electrum merged commit bec74be into airlift:master Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@electrum electrum deleted the electrum:checkstyle branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment