Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect heuristic for quantile digest node count #736

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@martint
Copy link
Member

commented Jun 3, 2019

The heuristic is valid for the quantile digest implementation described
in the original paper, but it doesn't work with our implementation
that requires intermediate nodes to capture the tree structure.

Relax the check and bound the count by the maximum theoretical number
of nodes for a complete binary tree that covers the domain.

Fix incorrect heuristic for quantile digest node count
The heuristic is valid for the quantile digest implementation described
in the original paper, but it doesn't work with our implementation
that requires intermediate nodes to capture the tree structure.

Relax the check and bound the count by the maximum theoretical number
of nodes for a complete binary tree that covers the domain.

@martint martint force-pushed the martint:qd-deserialize-fix branch from 02dcad1 to 831e380 Jun 3, 2019

@dain

dain approved these changes Jun 4, 2019

@martint martint merged commit 0dfeac3 into airlift:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.