Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log unhandled exceptions from server methods #115

Open
wants to merge 3 commits into
base: master
from

Conversation

@electrum
Copy link
Member

electrum commented Jan 8, 2020

No description provided.

electrum added 3 commits Jan 7, 2020
Thrift does not support exception causes, so attaching a cause
here is misleading, as it will be lost.
The future returned from the client is created immediately. It is not
the same future returned from the service handler on the server.
@electrum electrum requested a review from dain Jan 8, 2020
@dain
dain approved these changes Jan 9, 2020
Copy link
Member

dain left a comment

One comment

log.warn(exception, "Internal error processing method [%s]", methodMetadata.getName());
}

String message = format("Internal error processing method [%s]: %s", methodMetadata.getName(), exception.getMessage());

This comment has been minimized.

Copy link
@dain

dain Jan 9, 2020

Member

maybe generate message text once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.