New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent illegal access warnings on Java 9 #110

Merged
merged 9 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@electrum
Copy link
Member

electrum commented Dec 31, 2018

No description provided.

@electrum electrum changed the title # Requesting a pull to airlift:master from electrum:jol # # Write a message for this pull request. The first block # of text is the title and the rest is the description. Prevent illegal access warnings on Java 9 Dec 31, 2018

@electrum electrum requested a review from dain Dec 31, 2018

@electrum

This comment has been minimized.

Copy link
Member

electrum commented Dec 31, 2018

The first three commits are from #101

Remove private constructor usage for direct buffers
The buffer is created by duplicating the original buffer that is
referenced by the Slice object. This avoids illegal access warnings
on JDK 9, but does not allow creating buffers for Slices created via
UnsafeSliceFactory that access arbitrary memory locations.

@electrum electrum force-pushed the electrum:update branch from 69c64e6 to 49e0be2 Dec 31, 2018

@dain

dain approved these changes Jan 3, 2019

Copy link
Member

dain left a comment

Some comments on the simplifications resulting in extra allocations. Otherwise looks good

@electrum electrum merged commit 426eaf8 into airlift:master Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@electrum electrum deleted the electrum:update branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment