Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Passes spec if any version of PhantomJS is found in the launchers. (fixes #377) #378

Merged
merged 1 commit into from

2 participants

Duncan Bayne Toby Ho
Duncan Bayne

This spec was failing on my development machine because the version of
PhantomJS installed (1.6.0) didn't match the version hard-coded in the
assertion (1.9.0).

The fix was to make the test assert that any version of PhantomJS is
included, by matching the regex /^PhantomJS \d/.

Duncan Bayne duncan-bayne Passes spec if any version of PhantomJS is found in the launchers. (f…
…ixes #377)

This spec was failing on my development machine because the version of
PhantomJS installed (1.6.0) didn't match the version hard-coded in the
assertion (1.9.0).

The fix was to make the test assert that any version of PhantomJS is
included, by matching the regex /^PhantomJS \d/.
4f40a37
Toby Ho airportyh merged commit eca400b into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 20, 2014
  1. Duncan Bayne

    Passes spec if any version of PhantomJS is found in the launchers. (f…

    duncan-bayne authored
    …ixes #377)
    
    This spec was failing on my development machine because the version of
    PhantomJS installed (1.6.0) didn't match the version hard-coded in the
    assertion (1.9.0).
    
    The fix was to make the test assert that any version of PhantomJS is
    included, by matching the regex /^PhantomJS \d/.
This page is out of date. Refresh to see the latest.
Showing with 10 additions and 10 deletions.
  1. +10 −10 tests/ci/ci_tests.js
20 tests/ci/ci_tests.js
View
@@ -1,4 +1,4 @@
-var fs = require('fs')
+var fs = require('fs')
var App = require('../../lib/ci')
var TestReporter = require('../../lib/ci/test_reporters/tap_reporter')
var Config = require('../../lib/config')
@@ -16,7 +16,7 @@ describe('ci mode app', function(){
done()
})
})
-
+
it('runs them tests on node, nodetap, and browser', function(done){
this.timeout(10000)
var config = new Config('ci', {
@@ -43,27 +43,27 @@ describe('ci mode app', function(){
assert(helloWorld.every(function(r){
return r.result.passed
}), 'hello world should pass')
-
+
assert(helloBob.every(function(r){
return !r.result.passed
}), 'hello bob should fail')
-
+
assert(!nodePlain[0].result.passed, 'node plain should fail')
-
+
var launchers = reporter.results.map(function(r){
return r.launcher
})
-
+
assert.include(launchers, 'Node')
assert.include(launchers, 'NodePlain')
- assert.include(launchers, 'PhantomJS 1.9')
+ assert(launchers.some(function(n) { return n.match(/^PhantomJS \d/); }), 'Launchers should include some version of PhantomJS')
assert(reporter.results.length >= 1, 'should have a few launchers') // ball park?
assert(app.cleanExit.called, 'called process.exit()')
assert(app.cleanExit.lastCall.args[0], 0)
done()
})
-
+
})
})
@@ -212,7 +212,7 @@ describe('runHook', function(){
var app = new App(config)
stub(app, 'Process').returns(fakeP)
app.runHook('on_start', function(){
- assert.equal(app.Process.lastCall.args[0],
+ assert.equal(app.Process.lastCall.args[0],
'tunnel dev.app.com:2837 -u http://dev.app.com:2837/')
done()
})
@@ -269,4 +269,4 @@ describe('runHook', function(){
})
})
-})
+})
Something went wrong with that request. Please try again.