Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various minor issues found by LGTM #925

Merged
merged 2 commits into from Apr 28, 2019

Conversation

Projects
None yet
1 participant
@jvoisin
Copy link
Contributor

commented Mar 26, 2019

  • Unnecessary boxing
  • Integer overflow
  • Path traversal via zip
  • Dangerous synchronisation pattern

jvoisin added some commits Mar 26, 2019

Fix various minor issues found by LGTM
- Unnecessary boxing
- Integer overflow
- Path traversal via zip
- Dangerous synchronisation pattern

@jvoisin jvoisin merged commit d3970a5 into airsonic:master Apr 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jvoisin jvoisin deleted the jvoisin:misc_fix_lgtm branch Apr 28, 2019

@jvoisin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

The path traversal could lead to an RCE if the attacker is able to write a file in /var/airsonic/transcode/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.