BUG: Add MAMBARC support to mamba
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
|
Does this need a rebase now that #1372 is in? Does this need a specific test? |
HaoZeke
force-pushed
the
ctxMamba
branch
2 times, most recently
from
21f6c13
to
305340a
Compare
@mattip, I've rebased and added more tests covering all the additional features for the test/test_environment_bench.py::test_asv_mamba[with_conda_forge] PASSED [ 50%]
test/test_environment_bench.py::test_asv_mamba[empty_conda_channels] PASSED [ 62%]
test/test_environment_bench.py::test_asv_mamba_condarc[with_proper_condarc_and_mambarc] PASSED [ 75%]
test/test_environment_bench.py::test_asv_mamba_condarc[with_condarc_but_no_mambarc] PASSED [ 87%]
test/test_environment_bench.py::test_asv_mamba_condarc[without_condarc_and_mambarc] PASSED [100%] |
|
CI is not happy. It would be nice to have at least one windows (and maybe one macos) CI run to prove the code works on those platforms as well, since path parsing differs. |
HaoZeke
force-pushed
the
ctxMamba
branch
3 times, most recently
from
7680638
to
41623c1
Compare
mattip
reviewed
Feb 4, 2024
mattip
reviewed
Feb 4, 2024
Co-authored-by: mattip <mattip@users.noreply.github.com>
Co-authored-by: mattip <mattip@users.noreply.github.com>
|
@mattip I think this now ready. |
|
thanks @HaoZeke |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot be reviewed until #1372 is inCloses #1358. Also explicitly removes
conda-forgeas a default formamba. Users are free to either:.condarcand useexport MAMBARC=$HOME/.condarcor (better)
environment.ymlor set the corresponding variable inasv.conf.jsonThe documentation has also been updated to reflect the same.