Skip to content

Conversation

@paulodiniz
Copy link
Contributor

@paulodiniz paulodiniz commented Feb 25, 2021

resolves #1014

@chrismatix chrismatix changed the title Feature/1014 deploy the helm charts Deploy helm charts with the CLI Feb 26, 2021
@chrismatix chrismatix force-pushed the feature/1014-deploy-the-helm-charts branch from edac98f to 4aaf201 Compare February 26, 2021 16:52
@paulodiniz paulodiniz marked this pull request as ready for review March 1, 2021 08:18
@paulodiniz paulodiniz changed the title Deploy helm charts with the CLI [#1014] Deploy the helm charts Mar 1, 2021
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid work!

I'm requesting changes because of the UI flag but I admit I have a somewhat strong opinion also about the embedding of the configuration

@paulodiniz paulodiniz requested a review from lucapette March 2, 2021 14:18
@paulodiniz paulodiniz mentioned this pull request Mar 2, 2021
7 tasks
@chrismatix chrismatix force-pushed the feature/1014-deploy-the-helm-charts branch from 5a1bfff to 1131941 Compare March 3, 2021 14:02
chrismatix
chrismatix previously approved these changes Mar 3, 2021
@chrismatix chrismatix merged commit 96e2506 into develop Mar 3, 2021
@chrismatix chrismatix deleted the feature/1014-deploy-the-helm-charts branch March 3, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy the helm charts

5 participants