Restructure cli to prepare for providers #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
force-pushed
the
chore/restructure-cli
branch
from
5fdd30f to
d489c99
Compare
paulodiniz
reviewed
Mar 4, 2021
| ``` | ||
| -h, --help help for create | ||
| --provider string One of the supported providers (aws|local). Default is aws | ||
| --provider string One of the supported providers (aws|local|minikube). Default is aws (default "local") |
Contributor
There was a problem hiding this comment.
Isn't the minikube provider the equivalent of local?
Or, to put it differently? How do we use local provider without minikube?
Contributor
Author
There was a problem hiding this comment.
The local provider is only temporary until we do the minikube PR. It reflects the current cli api, but makes it explicit as a provider to allow for the restructuring.
chrismatix
force-pushed
the
chore/restructure-cli
branch
from
d489c99 to
bd04257
Compare
ljupcovangelski
previously approved these changes
Mar 4, 2021
paulodiniz
approved these changes
Mar 4, 2021
ljupcovangelski
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for #1041 and #1018
clipackagekubeconfigflag