Skip to content

[#1174] Build the right cli version on develop#1177

Merged
chrismatix merged 2 commits into
developfrom
fix/align-cli-version
Mar 9, 2021
Merged

[#1174] Build the right cli version on develop#1177
chrismatix merged 2 commits into
developfrom
fix/align-cli-version

Conversation

@chrismatix

Copy link
Copy Markdown
Contributor

fixes #1174

@github-actions github-actions Bot added the fix label Mar 9, 2021
@chrismatix chrismatix requested a review from lucapette as a code owner March 9, 2021 09:59

@pascal-holy pascal-holy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread tools/build/bazel_status.sh
load("@io_bazel_rules_docker//container:container.bzl", "container_push")

def container_release(registry, repository):
container_push(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@lucapette lucapette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chrismatix chrismatix merged commit 11ae58c into develop Mar 9, 2021
@chrismatix chrismatix deleted the fix/align-cli-version branch March 9, 2021 10:24
chrismatix pushed a commit that referenced this pull request Mar 10, 2021
lucapette added a commit that referenced this pull request Mar 10, 2021
* [#1174] Follow up fix to bug introduced by PR #1177

* allow for unset variables

* Fix

Co-authored-by: lucapette <ciao@lucapette.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop cli version not the same as pushed images

3 participants