Introduce /client.config #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucapette
force-pushed
the
feat/421-client-config
branch
from
9cc2a88
to
b6af628
Compare
paulodiniz
previously approved these changes
Jan 18, 2021
chrismatix
requested changes
Jan 18, 2021
| @@ -104,4 +106,10 @@ public ChannelsController(Api api, Stores stores) { | |||
| return ResponseEntity.status(HttpStatus.SERVICE_UNAVAILABLE).build(); | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public Health health() { | |||
There was a problem hiding this comment.
This indicator should already be on the Stores class
There was a problem hiding this comment.
will move all of them there! It's a better place :)
chrismatix
previously approved these changes
Jan 18, 2021
lucapette
force-pushed
the
feat/421-client-config
branch
from
b6af628
to
b48fb97
Compare
chrismatix
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.