Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Development server hot reload not working #17

Closed
alvinkl opened this issue Jan 23, 2019 · 1 comment · Fixed by #37

Comments

@alvinkl
Copy link
Collaborator

commented Jan 23, 2019

Describe the bug
During development by running maleo dev the server hot reload is not working.
getInitialProps not getting updated on server.

To Reproduce
Steps to reproduce the behavior:

  1. Run Maleo App in development environment
  2. Update getInitialProps on component
  3. Refresh page
  4. getInitialProps is still using the old one

Expected behavior
getInitialProps should be updated as well

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac OSX High Sierra
  • Browser Chrome
  • Version 71

Additional context
I believe this got something to do with the server side hot reload.
Currently it is not working

@alvinkl

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 21, 2019

Server and Client now use correct rebuild module, fixed at #33
getInitialProps also working

But Client HMR not working yet

@alvinkl alvinkl referenced this issue Feb 28, 2019
7 of 13 tasks complete
@alvinkl alvinkl closed this in #37 Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.