From 0659bdef8ce2301b164bf15bd1dd16d36a45eaf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Jas=CC=81tak?= Date: Mon, 14 Dec 2015 18:43:28 +0100 Subject: [PATCH] Constraint shouldn't implement Predicate. --- .../java/pl/ais/commons/bean/validation/Constraint.java | 4 +--- .../validation/constrainable/ConstrainableCollection.java | 6 ++++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/pl/ais/commons/bean/validation/Constraint.java b/src/main/java/pl/ais/commons/bean/validation/Constraint.java index 650bd71..815a0a2 100644 --- a/src/main/java/pl/ais/commons/bean/validation/Constraint.java +++ b/src/main/java/pl/ais/commons/bean/validation/Constraint.java @@ -7,7 +7,6 @@ import javax.annotation.Nonnull; import javax.annotation.Nullable; import java.util.function.BiFunction; -import java.util.function.Predicate; /** * Defines the API contract for the Constraint. @@ -17,7 +16,7 @@ * @author Warlock, AIS.PL * @since 1.2.1 */ -public interface Constraint, T> extends BiFunction, ValidationListener, Boolean>, Predicate { +public interface Constraint, T> extends BiFunction, ValidationListener, Boolean> { /** * Verifies if given constrainable matches the constraint and reports violation if needed. @@ -67,7 +66,6 @@ default Boolean apply(final Constrainable constrainable, final Vali * @param candidate value to be matched against this constraint * @return {@code true} if given argument matches this constraint, {@code false} otherwise */ - @Override boolean test(@Nullable T candidate); /** diff --git a/src/main/java/pl/ais/commons/bean/validation/constrainable/ConstrainableCollection.java b/src/main/java/pl/ais/commons/bean/validation/constrainable/ConstrainableCollection.java index c9abb6b..fec7d75 100644 --- a/src/main/java/pl/ais/commons/bean/validation/constrainable/ConstrainableCollection.java +++ b/src/main/java/pl/ais/commons/bean/validation/constrainable/ConstrainableCollection.java @@ -46,7 +46,8 @@ public static Constrainable allOf(final T first, final T second, final T. */ @Override public Boolean apply(final Constraint constraint) { - return elements.stream().allMatch(constraint); + return elements.stream() + .allMatch(constraint::test); } /** @@ -82,7 +83,8 @@ public static Constrainable anyOf(final T first, final T second, final T. */ @Override public Boolean apply(final Constraint constraint) { - return elements.stream().anyMatch(constraint); + return elements.stream() + .anyMatch(constraint::test); } /**