From 0dedadf29a2d8f82130cad423156d51fda8efe32 Mon Sep 17 00:00:00 2001 From: Jonas Keeling Date: Thu, 22 Feb 2024 23:00:34 +0100 Subject: [PATCH] bugfix: raise error in check_version if broker is unavailable This fixes an issue in check_version where KeyError is raised if the broker is unavailable or an invalid node_id is used. Instead it will return BrokerNotAvailableError. --- kafka/client_async.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kafka/client_async.py b/kafka/client_async.py index 2e3a680ff..a9dfd166b 100644 --- a/kafka/client_async.py +++ b/kafka/client_async.py @@ -911,7 +911,8 @@ def check_version(self, node_id=None, timeout=2, strict=False): if try_node is None: self._lock.release() raise Errors.NoBrokersAvailable() - self._maybe_connect(try_node) + if not self._maybe_connect(try_node): + raise Errors.BrokerNotAvailableError() conn = self._conns[try_node] # We will intentionally cause socket failures