Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored stream parsing #4

Merged
merged 1 commit into from May 26, 2015
Merged

Conversation

@Roach
Copy link

@Roach Roach commented May 14, 2015

The end-of-chunk detection was very flaky, so I implemented a way of passing the chunks to an array, then dumping the joined array to the data object. I've been running this patch for over a year, and I haven't lost a single streaming event. Prior to this, I was missing ~20% of emitted events.

@Roach Roach force-pushed the Roach:refactored_stream_parsing branch from f533d86 to 65069d5 May 14, 2015
aivis added a commit that referenced this pull request May 26, 2015
@aivis aivis merged commit 6eaa72e into aivis:master May 26, 2015
@aivis
Copy link
Owner

@aivis aivis commented May 26, 2015

@Roach Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.