Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename volumes field and treat as secret #8

Open
schrieveslaach opened this issue May 24, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@schrieveslaach
Copy link
Contributor

commented May 24, 2019

PREvant's REST-API allows to copy file contents into the container to be started by providing the volumes field at the REST endpoint POST /apps/{appName}. However, the name volumes is confusing because one might think that PREvant mounts a host file system path into the container. Therefore, this field should be renamed to avoid this confusion.

Additionally, this data should be handled as SecStr internally so that the sensitive information won't be leaked into a log file or something like that.

This should be done before releasing verion 1.0

@schrieveslaach schrieveslaach changed the title Rename volumes field Rename volumes field and treat as secret May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.