Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing support for secrets #7

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
3 participants
@schrieveslaach
Copy link
Contributor

commented May 22, 2019

Add configuration to define secrets for specific services for specific apps. These
secrets will be mounted in the container under /run/secrets/<name> so that the
service is able to use e.g. database credentials.

@schrieveslaach schrieveslaach requested review from x1B and qacwnfq May 22, 2019

@qacwnfq
Copy link

left a comment

LGTM

Show resolved Hide resolved api/src/models/service.rs Outdated
@x1B

x1B approved these changes May 23, 2019

Copy link
Contributor

left a comment

Apart from some "sacrificial ducks", this LGTM!

Show resolved Hide resolved api/src/services/config_service.rs Outdated
Show resolved Hide resolved api/src/services/config_service.rs
Show resolved Hide resolved api/src/services/config_service.rs Outdated
Implementing support for secrets
Add configuration to define secrets for specific services for specific apps. These
secrets will be mounted in the container under `/run/secrets/<name>` so that the
service is able to use e.g. database credentials.

Additionally, PREvant starts to use secstr so that credentials are not accidentally
leaked to the container log.

@schrieveslaach schrieveslaach merged commit 9912491 into master May 24, 2019

@schrieveslaach schrieveslaach deleted the secrets branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.