From 836c51f789711c30634930fe1bc50c30919451a3 Mon Sep 17 00:00:00 2001
From: xainaz <zaina.abushaban@gmail.com>
Date: Wed, 4 Sep 2024 18:51:57 +0300
Subject: [PATCH] Added name to update

---
 aixplain/modules/pipeline/asset.py        | 18 ++++++++++++------
 tests/functional/pipelines/create_test.py |  3 ++-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/aixplain/modules/pipeline/asset.py b/aixplain/modules/pipeline/asset.py
index 860a08a5..6933f601 100644
--- a/aixplain/modules/pipeline/asset.py
+++ b/aixplain/modules/pipeline/asset.py
@@ -262,10 +262,11 @@ def __prepare_payload(
                         dasset = DatasetFactory.get(str(data_asset[node_label]))
                         asset_payload["dataAsset"]["dataset_id"] = dasset.id
 
-                        if (
-                            len([dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]])
-                            > 0
-                        ):
+                        source_data_list = [
+                            dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]
+                        ]
+
+                        if len(source_data_list) > 0:
                             data_found = True
                         else:
                             for target in dasset.target_data:
@@ -341,9 +342,11 @@ def run_async(
                     error = "Validation-related error: Please ensure all required fields are provided and correctly formatted."
                 else:
                     status_code = str(r.status_code)
-                    error = f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
+                    error = (
+                        f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
+                    )
                 response = {"status": "FAILED", "error_message": error}
-                logging.error(f"Error in request for {name} - {r.status_code}: {error}")               
+                logging.error(f"Error in request for {name} - {r.status_code}: {error}")
         except Exception:
             response = {"status": "FAILED"}
             if resp is not None:
@@ -355,6 +358,7 @@ def update(
         pipeline: Union[Text, Dict],
         save_as_asset: bool = False,
         api_key: Optional[Text] = None,
+        name: Optional[Text] = None,
     ):
         """Update Pipeline
 
@@ -382,6 +386,8 @@ def update(
             status = "draft"
             if save_as_asset is True:
                 status = "onboarded"
+            if name:
+                self.name = name
             payload = {
                 "name": self.name,
                 "status": status,
diff --git a/tests/functional/pipelines/create_test.py b/tests/functional/pipelines/create_test.py
index 6431bd41..6cf3d718 100644
--- a/tests/functional/pipelines/create_test.py
+++ b/tests/functional/pipelines/create_test.py
@@ -54,7 +54,8 @@ def test_update_pipeline():
     pipeline_name = str(uuid4())
     pipeline = PipelineFactory.create(name=pipeline_name, pipeline=pipeline_dict)
 
-    pipeline.update(pipeline=pipeline_json, save_as_asset=True)
+    pipeline.update(pipeline=pipeline_json, save_as_asset=True, name="NEW NAME")
+    assert pipeline.name == "NEW NAME"
     assert isinstance(pipeline, Pipeline)
     assert pipeline.id != ""
     pipeline.delete()