Removing problematic finetuning test #85
Conversation
Signed-off-by: mikelam-us-aixplain <michael.lam@aixplain.com>
mikelam-us-aixplain
requested review from
krishnadurai,
lucas-aixplain and
shreyasXplain
| return request.param | ||
|
|
||
|
|
||
| ''' |
There was a problem hiding this comment.
Can you mark this test as skipped?
There was a problem hiding this comment.
@mikelam-us-aixplain, to remove AWS ASR from the tests, you should erase AWS ASR entry from the finetune_test_run_data.json file. It is the second element: https://github.com/aixplain/aiXplain/blob/M-5283031693-Removing-Problematic-Finetune_Test/tests/functional/finetune/data/finetune_test_run_data.json#L7C22-L8
Please also save a copy of the file with all suppliers as a backup.
There was a problem hiding this comment.
@lucas-aixplain why remove when this can be marked as skipped? We can leave a note to why it was marked as skipped.
There was a problem hiding this comment.
Here we do not need to skip the test method, we can just remove the problematic test case entry from the input JSON file and let the test run for other suppliers.
Signed-off-by: mikelam-us-aixplain <michael.lam@aixplain.com>
| return request.param | ||
|
|
||
|
|
||
| ''' |
There was a problem hiding this comment.
@mikelam-us-aixplain, to remove AWS ASR from the tests, you should erase AWS ASR entry from the finetune_test_run_data.json file. It is the second element: https://github.com/aixplain/aiXplain/blob/M-5283031693-Removing-Problematic-Finetune_Test/tests/functional/finetune/data/finetune_test_run_data.json#L7C22-L8
Please also save a copy of the file with all suppliers as a backup.
Signed-off-by: mikelam-us-aixplain <michael.lam@aixplain.com>
Signed-off-by: mikelam-us-aixplain <michael.lam@aixplain.com>
krishnadurai
deleted the
M-5283031693-Removing-Problematic-Finetune_Test
branch
Removing problematic fine-tuning test due to AWS rate-limiting until this problem is fixed.