Adding an optional playbutton param, to show a play button #20

Merged
merged 1 commit into from May 28, 2013

Projects

None yet

2 participants

@matthutchinson
Contributor

Having the song play after page load was a little annoying for me when I used the embeddable option. This commit introduces a new &playbutton param.

If present a link labelled ▸ Click to play is appended and the tune will not start until you click it.

A new global object songOfGitHub was introduced to deal with this, and allWeeks array was pulled up.

@matthutchinson matthutchinson adding optional playbutton param, to show a play button
having the song play after page load was a little annoying for me when I
used the embeddable option.  This commit introduces a new &playbutton
param.  If present a link labelled '▸ Click to play' is appended and the
tune will not start until you click it.

A new global object songOfGitHub was introduced to deal with this, and
allWeeks array was pulled up.
82e2ffc
@ajacksified
Owner

Thanks! 👍

@ajacksified ajacksified merged commit 82e2ffc into ajacksified:master May 28, 2013
@matthutchinson
Contributor

Great, and thanks for merging, let me know if/when you deploy it to http://song-of-github.herokuapp.com 👌

@matthutchinson
Contributor

Thanks, i've updated my blog post just now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment