Adding an optional playbutton param, to show a play button#20
Merged
Conversation
having the song play after page load was a little annoying for me when I used the embeddable option. This commit introduces a new &playbutton param. If present a link labelled '▸ Click to play' is appended and the tune will not start until you click it. A new global object songOfGitHub was introduced to deal with this, and allWeeks array was pulled up.
Owner
|
Thanks! 👍 |
Contributor
Author
|
Great, and thanks for merging, let me know if/when you deploy it to http://song-of-github.herokuapp.com 👌 |
Owner
Contributor
Author
|
Thanks, i've updated my blog post just now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the song play after page load was a little annoying for me when I used the embeddable option. This commit introduces a new
&playbuttonparam.If present a link labelled ▸ Click to play is appended and the tune will not start until you click it.
A new global object
songOfGitHubwas introduced to deal with this, andallWeeksarray was pulled up.