/song-of-github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an optional playbutton param, to show a play button #20

Merged
merged 1 commit into from May 28, 2013

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@matthutchinson @ajacksified
@matthutchinson
Contributor

matthutchinson commented May 28, 2013

Having the song play after page load was a little annoying for me when I used the embeddable option. This commit introduces a new &playbutton param.

If present a link labelled ▸ Click to play is appended and the tune will not start until you click it.

A new global object songOfGitHub was introduced to deal with this, and allWeeks array was pulled up.
@matthutchinson
adding optional playbutton param, to show a play button 
having the song play after page load was a little annoying for me when I
used the embeddable option.  This commit introduces a new &playbutton
param.  If present a link labelled '▸ Click to play' is appended and the
tune will not start until you click it.

A new global object songOfGitHub was introduced to deal with this, and
allWeeks array was pulled up.
82e2ffc
@ajacksified

This comment has been minimized.

Show comment
Hide comment
@ajacksified

ajacksified May 28, 2013

Owner

Thanks! 👍
Owner

ajacksified commented May 28, 2013

Thanks! 👍

@ajacksified ajacksified merged commit 82e2ffc into ajacksified:master May 28, 2013

@matthutchinson

This comment has been minimized.

Show comment
Hide comment
@matthutchinson

matthutchinson May 28, 2013

Contributor

Great, and thanks for merging, let me know if/when you deploy it to http://song-of-github.herokuapp.com 👌
Contributor

matthutchinson commented May 28, 2013

Great, and thanks for merging, let me know if/when you deploy it to http://song-of-github.herokuapp.com 👌
@ajacksified

This comment has been minimized.

Show comment
Hide comment
@ajacksified

ajacksified May 28, 2013

Owner

@matthutchinson just deployed! http://song-of-github.herokuapp.com/?username=ajacksified&playbutton
Owner

ajacksified commented May 28, 2013

@matthutchinson just deployed! http://song-of-github.herokuapp.com/?username=ajacksified&playbutton
@matthutchinson

This comment has been minimized.

Show comment
Hide comment
@matthutchinson

matthutchinson May 28, 2013

Contributor

Thanks, i've updated my blog post just now!
Contributor

matthutchinson commented May 28, 2013

Thanks, i've updated my blog post just now!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment