Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix firefox detection
  • Loading branch information
nightwing committed Nov 8, 2017
1 parent 0996bec commit ee9bdb7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 16 deletions.
9 changes: 3 additions & 6 deletions lib/ace/keyboard/textinput.js
Expand Up @@ -394,12 +394,9 @@ var TextInput = function(parentNode, host) {
var syncComposition = lang.delayedCall(onCompositionUpdate, 50);

event.addListener(text, "compositionstart", onCompositionStart);
if (useragent.isGecko) {
event.addListener(text, "text", function(){syncComposition.schedule();});
} else {
event.addListener(text, "keyup", function(){syncComposition.schedule();});
event.addListener(text, "keydown", function(){syncComposition.schedule();});
}
event.addListener(text, "compositionupdate", function(){syncComposition.schedule();});
event.addListener(text, "keyup", function(){syncComposition.schedule();});
event.addListener(text, "keydown", function(){syncComposition.schedule();});
event.addListener(text, "compositionend", onCompositionEnd);

this.getElement = function() {
Expand Down
9 changes: 3 additions & 6 deletions lib/ace/keyboard/textinput_ios.js
Expand Up @@ -383,12 +383,9 @@ var TextInput = function(parentNode, host) {
var syncComposition = lang.delayedCall(onCompositionUpdate, 50);

event.addListener(text, "compositionstart", onCompositionStart);
if (useragent.isGecko) {
event.addListener(text, "text", function(){syncComposition.schedule();});
} else {
event.addListener(text, "keyup", function(){syncComposition.schedule();});
event.addListener(text, "keydown", function(){syncComposition.schedule();});
}
event.addListener(text, "compositionupdate", function(){syncComposition.schedule();});
event.addListener(text, "keyup", function(){syncComposition.schedule();});
event.addListener(text, "keydown", function(){syncComposition.schedule();});
event.addListener(text, "compositionend", onCompositionEnd);

this.getElement = function() {
Expand Down
5 changes: 1 addition & 4 deletions lib/ace/lib/useragent.js
Expand Up @@ -82,10 +82,7 @@ exports.isIE =
exports.isOldIE = exports.isIE && exports.isIE < 9;

// Is this Firefox or related?
exports.isGecko = exports.isMozilla = (window.Controllers || window.controllers) && window.navigator.product === "Gecko";

// oldGecko == rev < 2.0
exports.isOldGecko = exports.isGecko && parseInt((ua.match(/rv:(\d+)/)||[])[1], 10) < 4;
exports.isGecko = exports.isMozilla = ua.match(/ Gecko\/\d+/);

// Is this Opera
exports.isOpera = window.opera && Object.prototype.toString.call(window.opera) == "[object Opera]";
Expand Down

0 comments on commit ee9bdb7

Please sign in to comment.