Document.remove() removes lines in backwards order

[ggoodman]

Because the order of deletion is last, middleLines, first, the change events that get fired are in reverse order. If you watch those change events, the attached Range objects do not contain relevant ranges.

The three blocks in the linked lines should be reversed:

https://github.com/ajaxorg/ace/blob/master/lib/ace/document.js#L436-L445

[nightwing]

What do you expect them to be?
for document

a0
1
2
3a

when removing number i get

{ action="removeText", range=Range: [3/0] -> [3/1], text="3"}
{ action="removeLines", range=Range: [1/0] -> [3/0], }
{ action="removeText", range=Range: [0/1] -> [0/2], text="0"}
{ action="removeText", range=Range: [0/1] -> [1/0], text="\n"}

with reversed order it would become

{ action="removeText", range=Range: [0/1] -> [0/2], text="0"}
{ action="removeLines", range=Range: [1/0] -> [3/0], }
{ action="removeText", range=Range: [1/0] -> [1/1], text="3"}
{ action="removeText", range=Range: [0/1] -> [1/0], text="\n"} // this can't be moved!

which is hardly any better.

Though it might be good to simplify deltas and have only insert and remove.

[ggoodman]

Thanks for responding @nightwing, you are right that the ranges appear correct after all and the issue was with my translation of those ranges to text offsets.

As for josephg/ShareJS#159 I'm not sure what the issue would be after all.