Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Command-G doesn't work correctly when focus is in search box #1309

Closed
etlovett opened this Issue Mar 15, 2013 · 0 comments

Comments

Projects
None yet
2 participants

Repro steps:

  1. Open http://ace.ajax.org/build/kitchen-sink.html. Ensure that the editor has focus (this should happen by default, but click into it if not).
  2. Type Command-F to bring up Ace's ext-searchbox for find.
  3. Type a search string that has multiple results (e.g. 'ascii' for the AsciiDoc example).
  4. Type Command-G to try to go to the next search result.

Instead of Ace jumping to the next search result, the browser's search bar is brought up. If you put the focus back into the editor before step 4, then this works as expected, but when the focus is in the search box, Ace does not properly intercept the Command-G keystroke.

Tested on OS X 10.7.5 in Firefox Beta 20.0, Chrome 25.0.1364.172, and Chrome 27.0.1438.7 dev. Does not reproduce in Safari 6.0.2 (7536.26.17) because Safari doesn't appear to support the Command-G key to bring up search.

@nightwing nightwing closed this in 243e95f Mar 17, 2013

@mostafaeweda mostafaeweda pushed a commit that referenced this issue Mar 17, 2013

Mostafa Eweda Merge pull request #1313 from ajaxorg/searchbox
fix #1309
8c2e30d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment