Skip to content

Turning off iBus Chinese input method issue #1325

Closed
tylerlong opened this Issue Mar 26, 2013 · 5 comments

2 participants

@tylerlong

One char after the cursor is deleted when turning off Chinese input.

Click mouse fix the issue. If you click mouse just before turning off Chinese input, the issue won't happen at all.

Refer to tylerlong/slimtext.org#16

@nightwing
Ajax.org B.V. member

I can't reproduce this.
Does this only happen when editor selection is empty? if so, adding !host.selection.isEmpty() check in https://github.com/ajaxorg/ace/blob/master/lib/ace/keyboard/textinput.js#L213. should help

@tylerlong

Steps to reproduce:

  1. Place cursor in the middle of some text
  2. ctrl + space to turn on Chinese input
  3. type some Chinese characters
  4. ctrl + space to turn off Chinese input
  5. you will notice that a character after the cursor is deleted

Don't click mouse between step 3 and step 4, otherwise the issue won't appear.

@nightwing nightwing added a commit that referenced this issue Mar 28, 2013
@nightwing nightwing allow delete command only after opening contextmenu
  this will break delete from browser edit menu, but it is not as important as ime textinput
  fixes #1325
0f4fd99
@nightwing
Ajax.org B.V. member

This happened only on chrome and only if ctrl+space wasn't remapped to something else (i had changed language switcher to alt+space to not interfere with autocompletion, and alt+space wasn't deleting anything)
Should be fixed on ime branch, please try https://rawgithub.com/ajaxorg/ace/ime/kitchen-sink.html.

@tylerlong

I Confirm that issue has been fixed. Tested on https://rawgithub.com/ajaxorg/ace/ime/kitchen-sink.html

Please release a new distribution package to the ace-builds project whenever possible.

@tylerlong tylerlong closed this Mar 29, 2013
@nightwing
Ajax.org B.V. member

Released today, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.