transformTextarea should be available in the standard Ace editor package #239

Closed
brion opened this Issue May 6, 2011 · 6 comments

Projects

None yet

5 participants

@brion
brion commented May 6, 2011

Currently the transformTextarea helper function & friends needed to transparently replace <textarea>s with Ace editors is only available in an alternate build tree which isn't quite compatible with the regular API (see also #199)

Many users would benefit from this being a standard part of the core Ace package.

via thread: http://groups.google.com/group/ace-discuss/browse_thread/thread/56023ca58fc3e27?hl=en
@gissues:{"order":76.39751552795042,"status":"backlog"}

@jviereck
Contributor
jviereck commented May 9, 2011

What should the transformation function return? Currently, it returns an JS object that holds some API to interact with the editor.

There's also the issue, that the current transformTextArea doesn't completely work on IE. That was why I kept the bookmarklet and other ace code separate as all the other ACE code runs on IE (expect the worker code, which is a "nice to have").

@brion
brion commented May 9, 2011

Assuming the question is about issue 119 (the textarea replacement function returning an object that is not compatible with the regular Ace editor API object that you receive when using the base package), the desired return value is an object that is the same, or is compatible with, the return value of ace.edit().

This issue requests having the textarea replacement system available in the base package, rather than needing to pull scripts from a second build tree.

@brion brion closed this May 9, 2011
@brion brion reopened this May 9, 2011
@brion
brion commented May 9, 2011

Sorry for the issue spam -- apparently github's "Comment & Close" closes the issue, not the view of the issue. Reopened.

@ramontayag

Would it be unwise to have non-IE working code in the main branch?

@Downchuck

The textarea replacement system is very simple, the issue with it is that it doesn't return the host "ace" object, and so we can't access common APIs from it.

@nightwing
Member

Closing since now ace.edit supports textarea elements, and the rest of transformTextarea is an optional extension, in the same build and is compatible with the regular API.

@nightwing nightwing closed this Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment