last line highlighting is cut off #934

Closed
Gozala opened this Issue Sep 12, 2012 · 2 comments

3 participants

@Gozala

Active line highlighter is cut off on the last line:

cut off

And it's not if cursor is not on the last line:

not cut off

@danyaPostfactum

Additionally, click on gutter selects line with line ending, but cursor is leaved on selected line instead of next line.

@danyaPostfactum

It'is really more complex that I have expected )
Lets tur'n on line wrapping and make editor narrow - bottom part of active line marker will covers text only, not full line.

This is because of {start: {row: $max, col: 0}, end: {row: $max+1, col: 0}} converts to {start: {row: $max, col: 0}, end: {row: $max, col: $max}}, because of row: $max+1 doesn't exist. That's why marker renderer draws marker as charwidth-based , instead of multiline mode)

I think marker should have some of type (types = ['line', 'range'] for example). active_line should have line type, text selection - range type. And marker drawer will render last active line marker correctly.

@nightwing nightwing added a commit that referenced this issue Oct 1, 2012
@nightwing nightwing fix line highlight on the last line
 Issue #934
ee65c53
@nightwing nightwing added a commit that referenced this issue Oct 13, 2012
@nightwing nightwing fix line highlight on the last line
 Issue #934
48aba93
@nightwing nightwing added a commit that referenced this issue Oct 26, 2012
@nightwing nightwing fix line highlight on the last line
 Issue #934
dfe918e
@nightwing nightwing closed this Dec 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment