Cursor improvements an new options (blinkInterval, smoothBlinking) #1002

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

danyaPostfactum commented Oct 2, 2012

No description provided.

Contributor

danyaPostfactum commented Oct 10, 2012

It seems smoothBlinking is badly needed option, but i would like to have blinkInterval option.
And timeoutId should also be cleared while timer reset, as well as visibility should be set to visible - we can cache visibility state in local var to prevent visibility reset when it's already has visible value (for the optimization).

It would be nice to cherry-pick 1,2,3 commits.

And wich way should be called CursorLayer.setBlinking method from default_handlers (startDrag/dragEnd)?
Maybe to dispatch dragStart / dragEnd events and set listeners to these events in editor.js ? These listeners will handle cursor blinking.

Member

nightwing commented Oct 15, 2012

It would be nice to cherry-pick 1,2,3 commits.
i somehow not quite like first three commits, wanted to change those a bit, but didn't have time for it yet sorry.
probably i'll merge as is and refactor later.

visibility state in local var to prevent
right that would be good

and set listeners to these events in editor.js
yes, but i am not sure if CursorLayer.setBlinking can be used for that since they will need to keep original value of blinking

Member

nightwing commented Oct 26, 2012

sorry for reviewing so late.
i've merged with some small changes.
but cursor layer still needs some work
it might be needed to restore optimization for one cursor case
add proper fade/hide (you had this in original patch)
also putting so many options into layer seems wrong, renderer should take care of options, layers should be simple

nightwing closed this Oct 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment