Fix JS highlight rules embedded in Jade #1016

Merged
merged 1 commit into from Oct 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

gjtorikian commented Oct 6, 2012

oops! I just noticed that JS highlighting rules embedded in Jade were not being highlighted. I'm not sure why I didn't do this in the beginning, maybe I forgot to get back to it?

@nightwing nightwing commented on the diff Oct 15, 2012

lib/ace/mode/jade_highlight_rules.js
"token": "source.js.embedded.jade",
- "regex": "^\\s*-|=|!=",
- "next": "js_code"
- },*/
+ "regex": "^\\s*(?:-|=|!=)",
@nightwing

nightwing Oct 15, 2012

Member

what is this shouldn't script tag start js mode?

@gjtorikian

gjtorikian Oct 15, 2012

Contributor

that is one of the ways--missing from this highlighter at the moment!

But you can also indicate javascript with - as a prefix; see:

https://github.com/miksago/jade-tmbundle/blob/master/Syntaxes/Jade.tmLanguage

or

https://github.com/visionmedia/jade#code

I'm not sure what != is for but it was in the original.

@nightwing nightwing added a commit that referenced this pull request Oct 18, 2012

@nightwing nightwing Merge pull request #1016 from ajaxorg/mode/jade
Fix JS highlight rules embedded in Jade
063e844

@nightwing nightwing merged commit 063e844 into master Oct 18, 2012

1 check passed

default The Travis build passed
Details
Member

nightwing commented Oct 18, 2012

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment