Skip to content

Add Emmet extension #1311

Merged
merged 7 commits into from Mar 30, 2013

3 participants

@nightwing
Ajax.org B.V. member

This adds implementation of IEmmetEditor interface for Ace, to make it easy to use emmet with it.
It doesn't include any of emmet code, which needs to be loaded from somewhere else

cc @mostafaeweda @lennartcl

@lennartcl
Ajax.org B.V. member

@nightwing My backspace key often acts funny after I try this. For example, try: id>(tab)(backspace)

@lennartcl lennartcl merged commit ac1835e into master Mar 30, 2013

1 check passed

Details default The Travis build passed
@lennartcl lennartcl deleted the emmet branch Mar 30, 2013
@danyaPostfactum danyaPostfactum commented on the diff Apr 18, 2013
lib/ace/ext/emmet.js
+ getSelection: function() {
+ return this.ace.session.getTextRange();
+ },
+
+ /**
+ * Returns current editor's file path
+ * @return {String}
+ * @since 0.65
+ */
+ getFilePath: function() {
+ return '';
+ }
+};
+
+
+var keymap = {

It lacks of wrap_with_abbreviation: "ctrl+shift+a" (or maybe Alt+W?) ((

@nightwing
Ajax.org B.V. member
nightwing added a note Apr 18, 2013

indeed, i wanted to add nicer editor.prompt first, but forgot.
alt+w is good too but on cloud9 will conflict with close tab shortcut

Can you add this with default prompt? later you can improve it if you want..

@nightwing
Ajax.org B.V. member
nightwing added a note May 27, 2013

added in 8530e38
btw should ace ext-emmet include emmet build or current way is good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gjtorikian gjtorikian referenced this pull request in atom/atom Jul 11, 2013
Closed

Emmet package #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.