Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for accent key composition in Chrome 53+ #3116

Merged
merged 1 commit into from Oct 28, 2016

Conversation

@jpallen
Copy link
Contributor

commented Oct 11, 2016

Should fix #3027, #3045, #3097, #3100. Fix was identified by @hoge1e3
in #3045

James Allen

@nightwing nightwing merged commit 98a31b3 into ajaxorg:master Oct 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iamwelk

This comment has been minimized.

Copy link

commented Nov 2, 2016

Excuse me. Can this fix the problem? How to use it in ace.js?

@iamwelk

This comment has been minimized.

Copy link

commented Nov 2, 2016

I have add the code, it works!! thank you~

@XVincentX

This comment has been minimized.

Copy link

commented Nov 8, 2016

@jpallen Is there any plan to release this fix as a public package (patch bump, probably)?

@ceritium ceritium referenced this pull request Dec 1, 2016

Gorash added a commit to odoo-dev/odoo that referenced this pull request Mar 19, 2018

alexkuhn added a commit to odoo/odoo that referenced this pull request Mar 20, 2018

[FIX] web: ace: no duplicated char with composition (html/css editor)
Before this commit, there was an issue with input method using
composition in which typed characters were duplicated.
This was occuring until the composition ended.

This is a bug specific to Google Chrome v53+.
It has been fixed in the most recent version of ace.js [1],
and we just port the fix into our custom code.

Note that we do not simply import ace.js as a whole, because
we must update lots of custom code at the same time.
We plan to do so in the future.

Fixes #23629

[1] ajaxorg/ace#3116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.