Make padding text specific to layer type, so that print margin and active line highlight are not affected. #343

Merged
merged 1 commit into from Jul 19, 2011

Conversation

Projects
None yet
3 participants
@Gozala
Contributor

Gozala commented Jul 14, 2011

Make padding text specific to layer type, so that print margin and active line highlight are not affected. #342

See before how active line highlight is cut of from both sides ? Also, print margin looks ugly because it's cut of on the end.

This patch is a fix for all of this to make it look like this:

after

fjakobs added a commit that referenced this pull request Jul 19, 2011

Merge pull request #343 from Gozala/bugs/paddings-342
Make padding text specific to layer type, so that print margin and active line highlight are not affected.

@fjakobs fjakobs merged commit 9f41f6c into ajaxorg:master Jul 19, 2011

@fjakobs

This comment has been minimized.

Show comment Hide comment
@fjakobs

fjakobs Jul 19, 2011

Contributor

nice one

Contributor

fjakobs commented Jul 19, 2011

nice one

@Gozala

This comment has been minimized.

Show comment Hide comment
@Gozala

Gozala Jul 20, 2011

Contributor

unfortunately this breaks full line selections
alt-text

for me full line selection works just fine

screenshot

maybe it will be better to keep padding-left at least
besides, with textMate theme, activeline cutted from the left looks better actually.

You can always add padding if you like it more in the theme itself...

Contributor

Gozala commented Jul 20, 2011

unfortunately this breaks full line selections
alt-text

for me full line selection works just fine

screenshot

maybe it will be better to keep padding-left at least
besides, with textMate theme, activeline cutted from the left looks better actually.

You can always add padding if you like it more in the theme itself...

@nightwing

This comment has been minimized.

Show comment Hide comment
@nightwing

nightwing Jul 20, 2011

Owner

my screenshot got broken somehow
https://sites.google.com/site/styleformath/a/untitledpost-1/Capture_25.jpg

but problem is visible on your screenshot too http://cl.ly/8auj
for multiline selections there is a gap between cursor and selection
and selection start (on i in your screenshot) is off by the size of old padding

Owner

nightwing commented Jul 20, 2011

my screenshot got broken somehow
https://sites.google.com/site/styleformath/a/untitledpost-1/Capture_25.jpg

but problem is visible on your screenshot too http://cl.ly/8auj
for multiline selections there is a gap between cursor and selection
and selection start (on i in your screenshot) is off by the size of old padding

@Gozala

This comment has been minimized.

Show comment Hide comment
@Gozala

Gozala Jul 20, 2011

Contributor

Ok I see now, I think it should be easy to fix. I'll try to do this.

Contributor

Gozala commented Jul 20, 2011

Ok I see now, I think it should be easy to fix. I'll try to do this.

@fjakobs

This comment has been minimized.

Show comment Hide comment
@fjakobs

fjakobs Jul 20, 2011

Contributor

I also observed this gap. @irakli can you look into it?

Contributor

fjakobs commented Jul 20, 2011

I also observed this gap. @irakli can you look into it?

@Gozala

This comment has been minimized.

Show comment Hide comment
@Gozala

Gozala Jul 20, 2011

Contributor

Yeap!

Contributor

Gozala commented Jul 20, 2011

Yeap!

@fjakobs

This comment has been minimized.

Show comment Hide comment
@fjakobs

fjakobs Jul 20, 2011

Contributor

thanks

Contributor

fjakobs commented Jul 20, 2011

thanks

@Gozala

This comment has been minimized.

Show comment Hide comment
@Gozala

Gozala Jul 20, 2011

Contributor

@fjakobs it seems this pull request no longer picks up new changes :(
Gozala/ace@2ed9c5d

I'll create a new one.

Contributor

Gozala commented Jul 20, 2011

@fjakobs it seems this pull request no longer picks up new changes :(
Gozala/ace@2ed9c5d

I'll create a new one.

@Gozala

This comment has been minimized.

Show comment Hide comment
@Gozala

Gozala Jul 20, 2011

Contributor

Created new pull request with discussed changes:
#347

Contributor

Gozala commented Jul 20, 2011

Created new pull request with discussed changes:
#347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment