Add Bash mode

[jamestyj]

Add support for Bash mode. Taken from besol/ace-mode-bash, with one small patch (susestudio/ace-mode-bash@44178c1eb1).
@gissues:{"order":46.58385093167726,"status":"backlog"}

[fjakobs]

Hi James,

thanks a lot for the bash mode. I was looking forward for a Bash contribution. Though before I can pull it I need to have a signed CLA from you. Check the bottom of the readme https://github.com/ajaxorg/ace/blob/master/Readme.md

[richo]

@jamestyj If you're cool with it, I'll make this a subclass of sh mode and probably rename it something like {z,ba}sh since most of their non-posix-isms are alike?

You would still need to sign the CLA though I presume.

[jamestyj]

I'm cool with that, but @jpgriffo did most of the work so I don't want to steal credit from him.

[jpgriffo]

Dont worry I about the credit I just want to see this project keep going at it should. Forward.

[fjakobs]

I have a CLA from @jpgriffo and @richoH. @jamestyj if the only change you did was susestudio/ace-mode-bash@44178c1eb1 then I think I don't have to have an CLA. However I'd prefer if you could send a corporate CLA just to be on the save side.

@richoH If possible I'd prefer just one shell mode with support for both bash and zsh. Maybe you can merge both.

[richo]

Cool. I was thinking along the lines of one for Bourne and one for zsh and bash.. but I can do one for all three. I might see if I can subtly highlight anything non-posix as a middleground.

[fjakobs]

cool

[jamestyj]

@jpgriffo Thanks!

@fjakobs Okay I'll check with our legal guys.

[jamestyj]

@fjakobs Conclusion is that it doesn't really make sense for our company to sign the CLA now for this simple patch. So we will only do that for bigger code submissions. Thanks for your understanding and from your comments this shouldn't be a problem.

[richo]

I finally got around to merging in the bash mode with the sh mode.

It's at #734

Sorry for the delay and thanks @jamestyj and @jpgriffo !

[richo]

#734 is merged, this PR can probably close?

[fjakobs]

@jamestyj that's fine. I'll wait for the bigger code submission :-)