New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bash mode #441

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jamestyj

jamestyj commented Sep 30, 2011

Add support for Bash mode. Taken from besol/ace-mode-bash, with one small patch (susestudio/ace-mode-bash@44178c1).
@gissues:{"order":46.58385093167726,"status":"backlog"}

James Tan
Add Bash mode.
Add Bash mode from https://github.com/susestudio/ace-mode-bash
(commit 44178c1eb1faae9a6b4b2c4da80883318f816a02).
@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Oct 4, 2011

Contributor

Hi James,

thanks a lot for the bash mode. I was looking forward for a Bash contribution. Though before I can pull it I need to have a signed CLA from you. Check the bottom of the readme https://github.com/ajaxorg/ace/blob/master/Readme.md

Contributor

fjakobs commented Oct 4, 2011

Hi James,

thanks a lot for the bash mode. I was looking forward for a Bash contribution. Though before I can pull it I need to have a signed CLA from you. Check the bottom of the readme https://github.com/ajaxorg/ace/blob/master/Readme.md

@richo

This comment has been minimized.

Show comment
Hide comment
@richo

richo Apr 4, 2012

Contributor

@jamestyj If you're cool with it, I'll make this a subclass of sh mode and probably rename it something like {z,ba}sh since most of their non-posix-isms are alike?

You would still need to sign the CLA though I presume.

Contributor

richo commented Apr 4, 2012

@jamestyj If you're cool with it, I'll make this a subclass of sh mode and probably rename it something like {z,ba}sh since most of their non-posix-isms are alike?

You would still need to sign the CLA though I presume.

@jamestyj

This comment has been minimized.

Show comment
Hide comment
@jamestyj

jamestyj Apr 4, 2012

I'm cool with that, but @jpgriffo did most of the work so I don't want to steal credit from him.

jamestyj commented Apr 4, 2012

I'm cool with that, but @jpgriffo did most of the work so I don't want to steal credit from him.

@jpgriffo

This comment has been minimized.

Show comment
Hide comment
@jpgriffo

jpgriffo Apr 4, 2012

Dont worry I about the credit I just want to see this project keep going at it should. Forward.

jpgriffo commented Apr 4, 2012

Dont worry I about the credit I just want to see this project keep going at it should. Forward.

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Apr 4, 2012

Contributor

I have a CLA from @jpgriffo and @richoH. @jamestyj if the only change you did was susestudio/ace-mode-bash@44178c1 then I think I don't have to have an CLA. However I'd prefer if you could send a corporate CLA just to be on the save side.

@richoH If possible I'd prefer just one shell mode with support for both bash and zsh. Maybe you can merge both.

Contributor

fjakobs commented Apr 4, 2012

I have a CLA from @jpgriffo and @richoH. @jamestyj if the only change you did was susestudio/ace-mode-bash@44178c1 then I think I don't have to have an CLA. However I'd prefer if you could send a corporate CLA just to be on the save side.

@richoH If possible I'd prefer just one shell mode with support for both bash and zsh. Maybe you can merge both.

@richo

This comment has been minimized.

Show comment
Hide comment
@richo

richo Apr 4, 2012

Contributor

Cool. I was thinking along the lines of one for Bourne and one for zsh and bash.. but I can do one for all three. I might see if I can subtly highlight anything non-posix as a middleground.

Contributor

richo commented Apr 4, 2012

Cool. I was thinking along the lines of one for Bourne and one for zsh and bash.. but I can do one for all three. I might see if I can subtly highlight anything non-posix as a middleground.

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Apr 4, 2012

Contributor

cool

Contributor

fjakobs commented Apr 4, 2012

cool

@jamestyj

This comment has been minimized.

Show comment
Hide comment
@jamestyj

jamestyj Apr 10, 2012

@jpgriffo Thanks!

@fjakobs Okay I'll check with our legal guys.

jamestyj commented Apr 10, 2012

@jpgriffo Thanks!

@fjakobs Okay I'll check with our legal guys.

@jamestyj

This comment has been minimized.

Show comment
Hide comment
@jamestyj

jamestyj Apr 10, 2012

@fjakobs Conclusion is that it doesn't really make sense for our company to sign the CLA now for this simple patch. So we will only do that for bigger code submissions. Thanks for your understanding and from your comments this shouldn't be a problem.

jamestyj commented Apr 10, 2012

@fjakobs Conclusion is that it doesn't really make sense for our company to sign the CLA now for this simple patch. So we will only do that for bigger code submissions. Thanks for your understanding and from your comments this shouldn't be a problem.

@richo

This comment has been minimized.

Show comment
Hide comment
@richo

richo Apr 18, 2012

Contributor

I finally got around to merging in the bash mode with the sh mode.

It's at #734

Sorry for the delay and thanks @jamestyj and @jpgriffo !

Contributor

richo commented Apr 18, 2012

I finally got around to merging in the bash mode with the sh mode.

It's at #734

Sorry for the delay and thanks @jamestyj and @jpgriffo !

@richo

This comment has been minimized.

Show comment
Hide comment
@richo

richo Apr 21, 2012

Contributor

#734 is merged, this PR can probably close?

Contributor

richo commented Apr 21, 2012

#734 is merged, this PR can probably close?

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Apr 23, 2012

Contributor

@jamestyj that's fine. I'll wait for the bigger code submission :-)

Contributor

fjakobs commented Apr 23, 2012

@jamestyj that's fine. I'll wait for the bigger code submission :-)

@fjakobs fjakobs closed this Apr 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment