Skip to content

Fix for timeout handling - fix #25 #26

Closed
wants to merge 1 commit into from

1 participant

@stefanjudis

Added callback for timeout event on given request.

@stefanjudis

In documentaion is written, that I can set up a timeout for the Github API call.

Unfortunately it is not triggering the given callback.

Reason for that the timeout according to node.js documentation.

When an idle timeout is triggered the socket will receive a 'timeout' event but the connection will not be severed. The user must manually end() or destroy() the socket.

Current behaviour:
Timeout is not triggering callback.

Wished behaviour:
Timeout is triggering callback with time error und status code 504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.